Skip to content

Commit 3886704

Browse files
committed
Temporarily silence a Rust error
The generated Rust code from our proto files triggers a warning in Rust nightly, which we treat as an error: error: custom inner attributes are unstable Error: --> src/../proto/metadata.rs:9:4 | 9 | #![rustfmt::skip] | ^^^^^^^^^^^^^ | = note: `#[deny(soft_unstable)]` on by default = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! = note: for more information, see issue #64266 <rust-lang/rust#64266> This is already reported in the `rust-protobuf` repo [1] so until it's fixed, we choose to silence this warning to make our builds work. [1]: stepancheg/rust-protobuf#551
1 parent bcd03db commit 3886704

File tree

2 files changed

+13
-0
lines changed

2 files changed

+13
-0
lines changed

CHANGELOG.md

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,16 @@ Versioning].
77

88
## [Unreleased]
99

10+
### Fixed
11+
12+
- Temporarily fix a build error for nightly Rust. In a nutshell, the generated
13+
Rust code for our proto files triggers a compiler warning in nightly Rust,
14+
which we ultimately treat as an error. Until this is fixed upstream, we
15+
silence this warning. See also:
16+
17+
* https://github.com/stepancheg/rust-protobuf/issues/551
18+
* https://github.com/rust-lang/rust/issues/64266
19+
1020
## [0.3.0] - 2021-01-11
1121

1222
### Added

src/lib.rs

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -39,6 +39,9 @@
3939
unused_results,
4040
variant_size_differences
4141
)]
42+
// FIXME: This must be removed once this is solved:
43+
// https://github.com/stepancheg/rust-protobuf/issues/551
44+
#![allow(soft_unstable)]
4245

4346
pub mod aead;
4447
pub mod cryptors;

0 commit comments

Comments
 (0)