Randomness commitment ext in Aptogotchi

[0xblockbard]

Heya, I have a question on the Aptogotchi randomness code implementation.

I see that the randomness commitment ext is a value tied to the contract address aptogotch_addr, and not an aptogotchi itself.

However, if there are multiple aptogotchis making moves, wouldn't this result in errors since for some of them the randomness commitment ext may not have been revealed yet?

struct RandomnessCommitmentExt has key {
        revealed: bool,
        value: u8,
    }

// Throw error if RandomnessCommitmentExt does not exist or is not committed
    fun check_randomness_commitment_exist_and_not_revealed(
        aptogotchi_address: address
    ) acquires RandomnessCommitmentExt {
        let exist_randomness_commitment_ext = exists<RandomnessCommitmentExt>(aptogotchi_address);
        assert!(exist_randomness_commitment_ext, ERANDOMNESS_COMMITMENT_NOT_EXIST);
        let random_commitment_ext = borrow_global<RandomnessCommitmentExt>(aptogotchi_address);
        assert!(!random_commitment_ext.revealed, EALREADY_REVEALED)
    }

// Used together with make_random_move_commit to reveal the random value.
    // If user doesn't reveal cause it doesn't like the result, it cannot enter the next round of game
    // In our case user cannot make another move without revealing the previous move
    // This function is only called from a transaction to prevent test and abort attack.
    entry fun make_random_move_reveal(
        aptogotchi_address: address,
    ) acquires Aptogotchi, RandomnessCommitmentExt {
        check_aptogotchi_exist_and_live(aptogotchi_address);
        let aptogotchi = borrow_global_mut<Aptogotchi>(aptogotchi_address);
        check_randomness_commitment_exist_and_not_revealed(aptogotchi_address);
        let random_commitment_ext = borrow_global_mut<RandomnessCommitmentExt>(aptogotchi_address);
        if (random_commitment_ext.value == 0) {
            aptogotchi.health = aptogotchi.health + 1;
        } else {
            aptogotchi.health = aptogotchi.health - 1;
            if (aptogotchi.health == 0) {
                aptogotchi.live = false;
            }
        };
        random_commitment_ext.revealed = true;
    }

Am I missing something here?

Link to code: https://learn.aptoslabs.com/en/code-examples/randomness

[0x-j]

i think the RandomnessCommitmentExt is indeed stored in the aptogotchi address, instead of contract address

https://github.com/aptos-labs/aptogotchi-random-mint/blob/main/move/sources/aptogotchi.move#L246

[0xblockbard]

I see, thanks! I think I might have mixed up the aptogotchi address as the aptogotchi contract address, which got me a little confused