-
Notifications
You must be signed in to change notification settings - Fork 118
Open
Labels
enhancementAn improvement to an existing feature.An improvement to an existing feature.supportProblems or questions reported by customers.Problems or questions reported by customers.
Description
We recently changed how MongoDB queries are sanitized to show more information to our users. (#819)
We can do the same to Redis commands. Currently, we are sanitizing the whole query and only showing the called command.
Example:
SET key value
SET ? ?
The idea is not to remove the command's first argument to know which keys are set up or retrieved.
appsignal-ruby/lib/appsignal/integrations/redis.rb
Lines 7 to 16 in d73905d
sanitized_command = | |
if command[0] == :eval | |
"#{command[1]}#{" ?" * (command.size - 3)}" | |
else | |
"#{command[0]}#{" ?" * (command.size - 1)}" | |
end | |
Appsignal.instrument "query.redis", id, sanitized_command do | |
super | |
end |
ToDo
- Allow the first argument of Redis commands
- Test properly with an alpha release to make sure we don't flood the DB with the new unique events
Metadata
Metadata
Assignees
Labels
enhancementAn improvement to an existing feature.An improvement to an existing feature.supportProblems or questions reported by customers.Problems or questions reported by customers.