From e805c246a7de8ab48c704cb2884a1886995ba3df Mon Sep 17 00:00:00 2001 From: Rafael Cepeda Date: Wed, 18 Jun 2025 22:37:40 +0100 Subject: [PATCH 1/4] Updated GA workflow and fixed sendability errors. --- .github/workflows/main.yml | 8 ++++---- Sources/RawStructuredFieldValues/ComponentTypes.swift | 2 +- Sources/StructuredFieldValues/DisplayString.swift | 2 +- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index 5f58168..d2649c7 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -12,10 +12,10 @@ jobs: uses: apple/swift-nio/.github/workflows/unit_tests.yml@main with: linux_5_10_arguments_override: "-Xswiftc -warnings-as-errors --explicit-target-dependency-import-check error" - linux_6_0_arguments_override: "-Xswiftc -warnings-as-errors --explicit-target-dependency-import-check error -Xswiftc -require-explicit-sendable" - linux_6_1_arguments_override: "-Xswiftc -warnings-as-errors --explicit-target-dependency-import-check error -Xswiftc -require-explicit-sendable" - linux_nightly_next_arguments_override: "--explicit-target-dependency-import-check error -Xswiftc -require-explicit-sendable" - linux_nightly_main_arguments_override: "--explicit-target-dependency-import-check error -Xswiftc -require-explicit-sendable" + linux_6_0_arguments_override: "-Xswiftc -warnings-as-errors --explicit-target-dependency-import-check error -Xswiftc -Xfrontend -Xswiftc -require-explicit-sendable" + linux_6_1_arguments_override: "-Xswiftc -warnings-as-errors --explicit-target-dependency-import-check error -Xswiftc -Xfrontend -Xswiftc -require-explicit-sendable" + linux_nightly_next_arguments_override: "--explicit-target-dependency-import-check error -Xswiftc -Xfrontend -Xswiftc -require-explicit-sendable" + linux_nightly_main_arguments_override: "--explicit-target-dependency-import-check error -Xswiftc -Xfrontend -Xswiftc -require-explicit-sendable" static-sdk: name: Static SDK diff --git a/Sources/RawStructuredFieldValues/ComponentTypes.swift b/Sources/RawStructuredFieldValues/ComponentTypes.swift index 5e641e1..c087275 100644 --- a/Sources/RawStructuredFieldValues/ComponentTypes.swift +++ b/Sources/RawStructuredFieldValues/ComponentTypes.swift @@ -276,7 +276,7 @@ extension BareInnerList: ExpressibleByArrayLiteral { // TODO: RangeReplaceableCollection I guess extension BareInnerList: RandomAccessCollection, MutableCollection { - public struct Index { + public struct Index: Sendable { fileprivate var baseIndex: Array.Index init(_ baseIndex: Array.Index) { diff --git a/Sources/StructuredFieldValues/DisplayString.swift b/Sources/StructuredFieldValues/DisplayString.swift index 2dfcf02..87c1737 100644 --- a/Sources/StructuredFieldValues/DisplayString.swift +++ b/Sources/StructuredFieldValues/DisplayString.swift @@ -13,7 +13,7 @@ //===----------------------------------------------------------------------===// /// A type that represents the Display String Structured Type. -public struct DisplayString: RawRepresentable, Codable, Equatable, Hashable { +public struct DisplayString: RawRepresentable, Codable, Equatable, Hashable, Sendable { public typealias RawValue = String public var rawValue: String From a8c01ed3edad8cac7e0ca1f89bef1995ee6ca6be Mon Sep 17 00:00:00 2001 From: Rafael Cepeda Date: Thu, 19 Jun 2025 16:37:45 +0100 Subject: [PATCH 2/4] Added require-explicit-sendable to macOS CI. --- .github/workflows/main.yml | 10 ++++++---- .github/workflows/pull_request.yml | 10 ++++++---- 2 files changed, 12 insertions(+), 8 deletions(-) diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index d2649c7..8308126 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -12,10 +12,10 @@ jobs: uses: apple/swift-nio/.github/workflows/unit_tests.yml@main with: linux_5_10_arguments_override: "-Xswiftc -warnings-as-errors --explicit-target-dependency-import-check error" - linux_6_0_arguments_override: "-Xswiftc -warnings-as-errors --explicit-target-dependency-import-check error -Xswiftc -Xfrontend -Xswiftc -require-explicit-sendable" - linux_6_1_arguments_override: "-Xswiftc -warnings-as-errors --explicit-target-dependency-import-check error -Xswiftc -Xfrontend -Xswiftc -require-explicit-sendable" - linux_nightly_next_arguments_override: "--explicit-target-dependency-import-check error -Xswiftc -Xfrontend -Xswiftc -require-explicit-sendable" - linux_nightly_main_arguments_override: "--explicit-target-dependency-import-check error -Xswiftc -Xfrontend -Xswiftc -require-explicit-sendable" + linux_6_0_arguments_override: "-Xswiftc -warnings-as-errors --explicit-target-dependency-import-check error" + linux_6_1_arguments_override: "-Xswiftc -warnings-as-errors --explicit-target-dependency-import-check error" + linux_nightly_next_arguments_override: "--explicit-target-dependency-import-check error" + linux_nightly_main_arguments_override: "--explicit-target-dependency-import-check error" static-sdk: name: Static SDK @@ -27,3 +27,5 @@ jobs: with: runner_pool: nightly build_scheme: swift-http-structured-headers-Package + xcode_16_2_build_arguments_override: "-Xswiftc -Xfrontend -Xswiftc -require-explicit-sendable" + xcode_16_3_build_arguments_override: "-Xswiftc -Xfrontend -Xswiftc -require-explicit-sendable" diff --git a/.github/workflows/pull_request.yml b/.github/workflows/pull_request.yml index 9989a6f..638c929 100644 --- a/.github/workflows/pull_request.yml +++ b/.github/workflows/pull_request.yml @@ -15,10 +15,10 @@ jobs: uses: apple/swift-nio/.github/workflows/unit_tests.yml@main with: linux_5_10_arguments_override: "-Xswiftc -warnings-as-errors --explicit-target-dependency-import-check error" - linux_6_0_arguments_override: "-Xswiftc -warnings-as-errors --explicit-target-dependency-import-check error -Xswiftc -require-explicit-sendable" - linux_6_1_arguments_override: "-Xswiftc -warnings-as-errors --explicit-target-dependency-import-check error -Xswiftc -require-explicit-sendable" - linux_nightly_next_arguments_override: "--explicit-target-dependency-import-check error -Xswiftc -require-explicit-sendable" - linux_nightly_main_arguments_override: "--explicit-target-dependency-import-check error -Xswiftc -require-explicit-sendable" + linux_6_0_arguments_override: "-Xswiftc -warnings-as-errors --explicit-target-dependency-import-check error" + linux_6_1_arguments_override: "-Xswiftc -warnings-as-errors --explicit-target-dependency-import-check error" + linux_nightly_next_arguments_override: "--explicit-target-dependency-import-check error" + linux_nightly_main_arguments_override: "--explicit-target-dependency-import-check error" cxx-interop: name: Cxx interop @@ -34,3 +34,5 @@ jobs: with: runner_pool: general build_scheme: swift-http-structured-headers-Package + xcode_16_2_build_arguments_override: "-Xswiftc -Xfrontend -Xswiftc -require-explicit-sendable" + xcode_16_3_build_arguments_override: "-Xswiftc -Xfrontend -Xswiftc -require-explicit-sendable" From 7cca0c2b2a590e8c3e4737a7b43a73f5657b12a6 Mon Sep 17 00:00:00 2001 From: Rafael Cepeda Date: Fri, 20 Jun 2025 12:46:54 +0100 Subject: [PATCH 3/4] Removed tab from yaml file. --- .github/workflows/pull_request.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/pull_request.yml b/.github/workflows/pull_request.yml index 638c929..b3339cc 100644 --- a/.github/workflows/pull_request.yml +++ b/.github/workflows/pull_request.yml @@ -34,5 +34,5 @@ jobs: with: runner_pool: general build_scheme: swift-http-structured-headers-Package - xcode_16_2_build_arguments_override: "-Xswiftc -Xfrontend -Xswiftc -require-explicit-sendable" + xcode_16_2_build_arguments_override: "-Xswiftc -Xfrontend -Xswiftc -require-explicit-sendable" xcode_16_3_build_arguments_override: "-Xswiftc -Xfrontend -Xswiftc -require-explicit-sendable" From b238a8d1d2aac94309abb7045958e836f2bb25d6 Mon Sep 17 00:00:00 2001 From: Rafael Cepeda Date: Fri, 20 Jun 2025 12:50:12 +0100 Subject: [PATCH 4/4] Removed bad characteres (pun intended) from Yaml file. --- .github/workflows/main.yml | 4 ++-- .github/workflows/pull_request.yml | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index 8308126..5f84572 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -27,5 +27,5 @@ jobs: with: runner_pool: nightly build_scheme: swift-http-structured-headers-Package - xcode_16_2_build_arguments_override: "-Xswiftc -Xfrontend -Xswiftc -require-explicit-sendable" - xcode_16_3_build_arguments_override: "-Xswiftc -Xfrontend -Xswiftc -require-explicit-sendable" + xcode_16_2_build_arguments_override: "-Xswiftc -Xfrontend -Xswiftc -require-explicit-sendable" + xcode_16_3_build_arguments_override: "-Xswiftc -Xfrontend -Xswiftc -require-explicit-sendable" diff --git a/.github/workflows/pull_request.yml b/.github/workflows/pull_request.yml index b3339cc..a0c735b 100644 --- a/.github/workflows/pull_request.yml +++ b/.github/workflows/pull_request.yml @@ -35,4 +35,4 @@ jobs: runner_pool: general build_scheme: swift-http-structured-headers-Package xcode_16_2_build_arguments_override: "-Xswiftc -Xfrontend -Xswiftc -require-explicit-sendable" - xcode_16_3_build_arguments_override: "-Xswiftc -Xfrontend -Xswiftc -require-explicit-sendable" + xcode_16_3_build_arguments_override: "-Xswiftc -Xfrontend -Xswiftc -require-explicit-sendable"