Skip to content

remove nodeSelector provisioner-nodepool #620

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

remove nodeSelector provisioner-nodepool #620

wants to merge 1 commit into from

Conversation

samos123
Copy link
Contributor

@samos123 samos123 commented Aug 2, 2024 •
edited
Loading

fix #619

@samos123 samos123 marked this pull request as draft August 2, 2024 23:41
@samos123 samos123 changed the title fix #619 remove nodeSelector provisioner-nodepool remove nodeSelector provisioner-nodepool Aug 3, 2024
ruomingp
ruomingp reviewed Aug 28, 2024
View reviewed changes
Copy link
Contributor

@ruomingp ruomingp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a unittest that can be updated?

@samos123 samos123 closed this Apr 4, 2025
@samos123 samos123 mentioned this pull request Apr 4, 2025
Merged
@samos123
Copy link
Contributor Author

samos123 commented Apr 4, 2025

Closed in favor of #1096

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruomingp ruomingp ruomingp left review comments

@markblee markblee Awaiting requested review from markblee

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

nodeSelector set by default requires tpu provisioner
2 participants
@samos123 @ruomingp