chore: expose all validation options

Author: mo4islona

.changeset/validate-options.md

@@ -0,0 +1,12 @@
+---
+'@apollo/server': minor
+---
+
+Expose `graphql` validation options.
+
+```
+const server = new ApolloServer({
+  typeDefs,
+  resolvers,
+  validateOptions: { maxErrors: 10 },
+});

.changeset/validation-max-errors.md

@@ -14,6 +14,7 @@ import {
   assertValidSchema,
   print,
   printSchema,
+  type validate,
   type DocumentNode,
   type FormattedExecutionResult,
   type GraphQLFieldResolver,
@@ -152,11 +153,12 @@ type ServerState =
       stopError: Error | null;
     };
 
+export type ValidateOptions = NonNullable<Parameters<typeof validate>[3]>;
+
 export interface ApolloServerInternals<TContext extends BaseContext> {
   state: ServerState;
   gatewayExecutor: GatewayExecutor | null;
   dangerouslyDisableValidation?: boolean;
-  validationMaxErrors?: number;
   formatError?: (
     formattedError: GraphQLFormattedError,
     error: unknown,
@@ -168,6 +170,7 @@ export interface ApolloServerInternals<TContext extends BaseContext> {
   apolloConfig: ApolloConfig;
   plugins: ApolloServerPlugin<TContext>[];
   parseOptions: ParseOptions;
+  validationOptions: ValidateOptions;
   // `undefined` means we figure out what to do during _start (because
   // the default depends on whether or not we used the background version
   // of start).
@@ -305,7 +308,7 @@ export class ApolloServer<in out TContext extends BaseContext = BaseContext> {
       hideSchemaDetailsFromClientErrors,
       dangerouslyDisableValidation:
         config.dangerouslyDisableValidation ?? false,
-      validationMaxErrors: config.validationMaxErrors,
+      validationOptions: config.validationOptions ?? {},
       fieldResolver: config.fieldResolver,
       includeStacktraceInErrorResponses:
         config.includeStacktraceInErrorResponses ??

packages/server/src/ApolloServer.ts

@@ -1201,7 +1201,7 @@ describe('parsing and validation cache', () => {
       });
       await server.start();
 
-      const vars = new Array(1000).fill(`$a:a`).join(',');
+      const vars = new Array(1000).fill('$a:a').join(',');
       const query = `query aaa (${vars}) { a }`;
 
       const res = await server.executeOperation({ query });
@@ -1214,14 +1214,15 @@ describe('parsing and validation cache', () => {
       expect(body.errors).toHaveLength(101);
       await server.stop();
     });
+
     it('aborts the validation if max errors more than expected', async () => {
       const server = new ApolloServer({
         schema,
-        validationMaxErrors: 1,
+        validationOptions: { maxErrors: 1 },
       });
       await server.start();
 
-      const vars = new Array(1000).fill(`$a:a`).join(',');
+      const vars = new Array(1000).fill('$a:a').join(',');
       const query = `query aaa (${vars}) { a }`;
 
       const res = await server.executeOperation({ query });

packages/server/src/__tests__/runQuery.test.ts

@@ -20,6 +20,7 @@ import type { GatewayInterface } from '@apollo/server-gateway-interface';
 import type { ApolloServerPlugin } from './plugins.js';
 import type { BaseContext } from './index.js';
 import type { GraphQLExperimentalIncrementalExecutionResults } from '../incrementalDeliveryPolyfill.js';
+import type { ValidateOptions } from '../ApolloServer.js';
 
 export type DocumentStore = KeyValueCache<DocumentNode>;
 
@@ -101,7 +102,7 @@ interface ApolloServerOptionsBase<TContext extends BaseContext> {
   nodeEnv?: string;
   documentStore?: DocumentStore | null;
   dangerouslyDisableValidation?: boolean;
-  validationMaxErrors?: number;
+  validationOptions?: ValidateOptions;
   csrfPrevention?: CSRFPreventionOptions | boolean;
 
   // Used for parsing operations; unlike in AS3, this is not also used for

packages/server/src/externalTypes/constructor.ts

@@ -247,7 +247,7 @@ export async function processGraphQLRequest<TContext extends BaseContext>(
         schemaDerivedData.schema,
         requestContext.document,
         [...specifiedRules, ...internals.validationRules],
-        { maxErrors: internals.validationMaxErrors },
+        internals.validationOptions,
       );
 
       if (validationErrors.length === 0) {