Skip to content

Commit 24eec20

Browse files
BoDBoD
authored
Java Codegen: add some @SuppressWarnings("unchecked") (#6434)
* Add some @SuppressWarnings("unchecked") * Regenerate expected
1 parent 44f9ab1 commit 24eec20

File tree

452 files changed

+1306
-100
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

452 files changed

+1306
-100
lines changed

‎libraries/apollo-compiler/src/main/kotlin/com/apollographql/apollo/compiler/codegen/java/helpers/BuilderBuilder.kt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@ internal class BuilderBuilder(
2121
fun build(): TypeSpec {
2222
return TypeSpec.classBuilder(JavaClassNames.Builder.simpleName())
2323
.addModifiers(Modifier.PUBLIC, Modifier.STATIC, Modifier.FINAL)
24+
.addAnnotation(suppressAnnotation("unchecked"))
2425
.addFields(builderFields())
2526
.addMethod(MethodSpec.constructorBuilder().build())
2627
.addMethods(fieldSetterMethodSpecs())

‎libraries/apollo-compiler/src/main/kotlin/com/apollographql/apollo/compiler/codegen/java/helpers/Deprecated.kt

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,10 @@
11
package com.apollographql.apollo.compiler.codegen.java.helpers
22

33
import com.apollographql.apollo.compiler.codegen.java.JavaClassNames
4-
import com.apollographql.apollo.compiler.codegen.java.S
54
import com.squareup.javapoet.AnnotationSpec
65

76
internal fun deprecatedAnnotation() = AnnotationSpec
87
.builder(JavaClassNames.Deprecated)
98
.build()
109

11-
internal fun suppressDeprecatedAnnotation() = AnnotationSpec.builder(JavaClassNames.SuppressWarnings)
12-
.addMember("value", S, "deprecation")
13-
.build()
10+
internal fun suppressDeprecatedAnnotation() = suppressAnnotation("deprecation")

‎libraries/apollo-compiler/src/main/kotlin/com/apollographql/apollo/compiler/codegen/java/helpers/Suppress.kt

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,9 @@
1+
package com.apollographql.apollo.compiler.codegen.java.helpers
2+
3+
import com.apollographql.apollo.compiler.codegen.java.JavaClassNames
4+
import com.apollographql.apollo.compiler.codegen.java.S
5+
import com.squareup.javapoet.AnnotationSpec
6+
7+
internal fun suppressAnnotation(value: String) = AnnotationSpec.builder(JavaClassNames.SuppressWarnings)
8+
.addMember("value", S, value)
9+
.build()

‎libraries/apollo-compiler/src/main/kotlin/com/apollographql/apollo/compiler/codegen/java/operations/CompiledSelectionsBuilder.kt

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@ import com.apollographql.apollo.compiler.codegen.java.L
77
import com.apollographql.apollo.compiler.codegen.java.S
88
import com.apollographql.apollo.compiler.codegen.java.T
99
import com.apollographql.apollo.compiler.codegen.java.helpers.codeBlock
10+
import com.apollographql.apollo.compiler.codegen.java.helpers.suppressAnnotation
1011
import com.apollographql.apollo.compiler.codegen.java.helpers.toListInitializerCodeblock
1112
import com.apollographql.apollo.compiler.ir.BVariable
1213
import com.apollographql.apollo.compiler.ir.BooleanExpression
@@ -29,6 +30,7 @@ internal class CompiledSelectionsBuilder(
2930
return TypeSpec.classBuilder(rootName)
3031
.addModifiers(Modifier.PUBLIC)
3132
.addFields(selectionSets.map { it.fieldSpec() })
33+
.addAnnotation(suppressAnnotation("unchecked"))
3234
.build()
3335
}
3436

‎libraries/apollo-compiler/src/main/kotlin/com/apollographql/apollo/compiler/codegen/java/operations/util/MonomorphicFieldResponseAdapterBuilder.kt

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@ import com.apollographql.apollo.compiler.codegen.java.JavaClassNames
99
import com.apollographql.apollo.compiler.codegen.java.JavaContext
1010
import com.apollographql.apollo.compiler.codegen.java.helpers.readFromResponseCodeBlock
1111
import com.apollographql.apollo.compiler.codegen.java.helpers.responseNamesFieldSpec
12+
import com.apollographql.apollo.compiler.codegen.java.helpers.suppressAnnotation
1213
import com.apollographql.apollo.compiler.codegen.java.helpers.toClassName
1314
import com.apollographql.apollo.compiler.codegen.java.helpers.writeToResponseCodeBlock
1415
import com.apollographql.apollo.compiler.ir.IrModel
@@ -74,6 +75,7 @@ internal class MonomorphicFieldResponseAdapterBuilder(
7475
private fun readFromResponseMethodSpec(): MethodSpec {
7576
return MethodSpec.methodBuilder(fromJson)
7677
.addModifiers(Modifier.PUBLIC)
78+
.addAnnotation(suppressAnnotation("unchecked"))
7779
.returns(adaptedClassName)
7880
.addException(JavaClassNames.IOException)
7981
.addParameter(JavaClassNames.JsonReader, reader)

‎libraries/apollo-compiler/src/test/graphql/com/example/antlr_tokens/java/operationBased/antlr_tokens/TestQuery.java.expected

Lines changed: 2 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎libraries/apollo-compiler/src/test/graphql/com/example/antlr_tokens/java/operationBased/antlr_tokens/adapter/TestQuery_ResponseAdapter.java.expected

Lines changed: 3 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎libraries/apollo-compiler/src/test/graphql/com/example/antlr_tokens/java/operationBased/antlr_tokens/selections/TestQuerySelections.java.expected

Lines changed: 2 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎libraries/apollo-compiler/src/test/graphql/com/example/arguments_hardcoded/java/operationBased/arguments_hardcoded/TestQuery.java.expected

Lines changed: 2 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎libraries/apollo-compiler/src/test/graphql/com/example/arguments_hardcoded/java/operationBased/arguments_hardcoded/adapter/TestQuery_ResponseAdapter.java.expected

Lines changed: 3 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)