Skip to content

Commit 65715a5

Browse files
committed
clippy: whitelist a bunch of lints
Copy the list of whitelisted lints from BlockstreamResearch/simfony. The "uninlined format args" one was the only one that was currently triggering here.
1 parent bacfb03 commit 65715a5

File tree

2 files changed

+20
-0
lines changed

2 files changed

+20
-0
lines changed

Cargo.toml

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -73,3 +73,13 @@ required-features = ["rand", "std"]
7373
[workspace]
7474
members = ["secp256k1-sys"]
7575
exclude = ["no_std_test"]
76+
77+
[lints.clippy]
78+
# Exclude lints we don't think are valuable.
79+
large_enum_variant = "allow" # docs say "measure before paying attention to this"; why is it on by default??
80+
similar_names = "allow" # Too many (subjectively) false positives.
81+
uninlined_format_args = "allow" # This is a subjective style choice.
82+
indexing_slicing = "allow" # Too many false positives ... would be cool though
83+
match_bool = "allow" # Adds extra indentation and LOC.
84+
match_same_arms = "allow" # Collapses things that are conceptually unrelated to each other.
85+
must_use_candidate = "allow" # Useful for audit but many false positives.

secp256k1-sys/Cargo.toml

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -35,3 +35,13 @@ alloc = []
3535

3636
[lints.rust]
3737
unexpected_cfgs = { level = "deny", check-cfg = ['cfg(bench)', 'cfg(secp256k1_fuzz)', 'cfg(rust_secp_no_symbol_renaming)'] }
38+
39+
[lints.clippy]
40+
# Exclude lints we don't think are valuable.
41+
large_enum_variant = "allow" # docs say "measure before paying attention to this"; why is it on by default??
42+
similar_names = "allow" # Too many (subjectively) false positives.
43+
uninlined_format_args = "allow" # This is a subjective style choice.
44+
indexing_slicing = "allow" # Too many false positives ... would be cool though
45+
match_bool = "allow" # Adds extra indentation and LOC.
46+
match_same_arms = "allow" # Collapses things that are conceptually unrelated to each other.
47+
must_use_candidate = "allow" # Useful for audit but many false positives.

0 commit comments

Comments
 (0)