Remove unlocking requests from BasicCrawler #2840

New issue

Copy link

New issue

Copy link

Open

#3014

Open

Remove unlocking requests from BasicCrawler#2840

#3014

Copy link

Labels

debtCode quality improvement or decrease of technical debt.Code quality improvement or decrease of technical debt.t-toolingIssues with this label are in the ownership of the tooling team.Issues with this label are in the ownership of the tooling team.

Milestone

4.0

Description

janbuchar

opened on Feb 10, 2025

Issue body actions

• See

  crawlee/packages/basic-crawler/src/internals/basic-crawler.ts

  Line 1486 in dc9060a

  await source.client.deleteRequestLock(request.id!);

• Introduced in 57fcb08
  • I assume this was to make sure that locks are deleted even when markRequestAsHandled calls fail for some reason
• BasicCrawler should not be concerned with request locking, period

👍React with 👍2drobnikj and CodeMan62

Metadata

Metadata

Assignees

No one assigned

Labels

debtCode quality improvement or decrease of technical debt.Code quality improvement or decrease of technical debt.t-toolingIssues with this label are in the ownership of the tooling team.Issues with this label are in the ownership of the tooling team.

Type

No type

Projects

No projects

Milestone

• 4.0No due date

Relationships

None yet

Development

No branches or pull requests

Issue actions