Dependency Update Forcing Node.js v20 - Request for Awareness #2515
wojtekKrol
started this conversation in
General
Replies: 1 comment 3 replies
-
FYI this is just a constraint, it works just fine with node 16. |
Beta Was this translation helpful? Give feedback.
3 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
-
Hello,
First, I'd like to express my appreciation for the excellent work done on the
amplify crawlee
library and its associated packages, including@crawlee/playwright
,@crawlee/utils
, and others. Your contributions are invaluable to the developer community.I am writing to bring to your attention an issue related to the recent dependency updates, specifically concerning the
got-scraping
package. Currently,@crawlee/playwright
depends on@crawlee/utils
, which in turn depends ongot-scraping
with the version specified as"got-scraping": "^4.0.0"
.The caret (
^
) character in the version specification allows for updates that do not change the leftmost non-zero digit, which means that version^4.0.0
includes all minor and patch updates, including4.x.x
.In
got-scraping
version4.0.5
, thegot
package dependency was updated from^13.0.0
to^14.2.1
. This change is significant because:got
version13.0.0
requires Node.js>=16
.got
version14.0.0
requires Node.js>=20
.As a result, this forces developers to use Node.js v20 when they update to the latest
got-scraping
version within the^4.0.0
range. This requirement can be quite disruptive, especially for those who are not yet ready to upgrade their Node.js environment to version 20.Additionally, it's important to note that
got-scraping
was updated from^3.2.15
to^4.0.0
incrawlee
version3.6.0
, which means this issue affects all versions ofcrawlee
released after3.6.0
.This problem affects not only the
amplify crawlee
packages but also any other packages that usegot-scraping
with the caret (^
) character in their version specification. The cascading effect of this dependency update can have a widespread impact on the developer community.For those affected by this issue, there are workarounds available that support 16 >= Node.js:
package.json
to override the latestgot-scraping
version:package.json
to resolve thegot-scraping
version:Could you please review this dependency update and consider the impact on the broader developer community? An interim solution could be pinning the
got-scraping
dependency to a version prior to4.0.5
until a broader consensus or transition plan is in place for requiring Node.js v20.Thank you for your understanding and consideration.
Best regards,
Wojciech
Below is an error thrown once we won't override:
Beta Was this translation helpful? Give feedback.
All reactions