Skip to content

Commit 2eb68e9

Browse files
author
Sebi Nemeth
committed
add relative wrapper to badge containers to support scrolling
1 parent c8d77e7 commit 2eb68e9

File tree

2 files changed

+18
-3
lines changed

2 files changed

+18
-3
lines changed

dist/index.js

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,11 @@ const css = `
2929
border-radius: 100%;
3030
background-color: red;
3131
}
32+
.live-translator-badge-wrapper {
33+
position: relative !important;
34+
width: 0px;
35+
height: 0px;
36+
}
3237
.live-translator-badge-container {
3338
position: absolute !important;
3439
display: flex;
@@ -222,7 +227,10 @@ class LiveTranslatorManager {
222227
else {
223228
container = document.createElement('span');
224229
container.classList.add('live-translator-badge-container');
225-
parent.insertBefore(container, node);
230+
const relativeWrapper = document.createElement('span');
231+
relativeWrapper.classList.add('live-translator-badge-wrapper');
232+
relativeWrapper.appendChild(container);
233+
parent.insertBefore(relativeWrapper, node);
226234
}
227235
for (const badge of badges) {
228236
container.appendChild(badge);

src/index.ts

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,11 @@ const css = `
2424
border-radius: 100%;
2525
background-color: red;
2626
}
27+
.live-translator-badge-wrapper {
28+
position: relative !important;
29+
width: 0px;
30+
height: 0px;
31+
}
2732
.live-translator-badge-container {
2833
position: absolute !important;
2934
display: flex;
@@ -121,7 +126,6 @@ abstract class ZeroWidthEncoder {
121126
class LiveTranslatorManager {
122127
_enabled: boolean
123128
_options: LiveTranslatorPluginOptions
124-
_callback: CallableFunction
125129

126130
_enableButton: HTMLButtonElement
127131
_indicator: HTMLSpanElement
@@ -259,7 +263,10 @@ class LiveTranslatorManager {
259263
} else {
260264
container = document.createElement('span')
261265
container.classList.add('live-translator-badge-container')
262-
parent.insertBefore(container, node)
266+
const relativeWrapper = document.createElement('span')
267+
relativeWrapper.classList.add('live-translator-badge-wrapper')
268+
relativeWrapper.appendChild(container)
269+
parent.insertBefore(relativeWrapper, node)
263270
}
264271
for (const badge of badges) {
265272
container.appendChild(badge)

0 commit comments

Comments
 (0)