Remove bare returns

julienschmidt · julienschmidt · commit ca14a4f911b8 · 2020-08-14T20:16:42.000+02:00
diff --git a/path_test.go b/path_test.go
@@ -120,7 +120,7 @@ func genLongPaths() (testPaths []cleanPathTest) {
 			result: correctPath,
 		})
 	}
-	return
+	return testPaths
 }
 
 func TestPathCleanLong(t *testing.T) {
diff --git a/router.go b/router.go
@@ -453,7 +453,8 @@ func (r *Router) allowed(path, reqMethod string) (allow string) {
 		// return as comma separated list
 		return strings.Join(allowed, ", ")
 	}
-	return
+
+	return allow
 }
 
 // ServeHTTP makes the router implement the http.Handler interface.

Original file line number	Diff line number	Diff line change
`@@ -120,7 +120,7 @@ func genLongPaths() (testPaths []cleanPathTest) {`
`120`	`120`	`result: correctPath,`
`121`	`121`	`})`
`122`	`122`	`}`
`123`		`- return`
	`123`	`+ return testPaths`
`124`	`124`	`}`
`125`	`125`
`126`	`126`	`func TestPathCleanLong(t *testing.T) {`
Original file line number	Diff line number	Diff line change
`@@ -453,7 +453,8 @@ func (r *Router) allowed(path, reqMethod string) (allow string) {`
`453`	`453`	`// return as comma separated list`
`454`	`454`	`return strings.Join(allowed, ", ")`
`455`	`455`	`}`
`456`		`- return`
	`456`	`+`
	`457`	`+ return allow`
`457`	`458`	`}`
`458`	`459`
`459`	`460`	`// ServeHTTP makes the router implement the http.Handler interface.`