[Bug] HashCodeSelector#select java.lang.ArrayIndexOutOfBoundsException: -8

[lihwstudy]

Search before asking

• I had searched in the issues and found no similar issues.

Apache SkyWalking Component

OAP server (apache/skywalking)

What happened

I current use Skywalking OAP Server 8.5.0 , receiver's log file print error：

java.lang.ArrayIndexOutOfBoundsException: -8
at com.google.common.collect.RegulatImmutableList.get(RegularImmutableList.java:75) ~[guava-28.1-jre.jar:?]
at org.apache.skywalking,oap.server.core.remote.selector.HashCodeSelector.select(HashCodeSelector.java;31) ~[server-core-8.5.0.jar:8.5.0]
at org.apache.skywalking,oap.server.core.remote.RemoteSenderService,send(RemoteSenderService.java:75) ~[server-core-8.5.0.jar:8.5.0]
at org.apache.skywalking,oap.server.core.analysis.worker.MetricsRemoteWorker.in(MetricsRemoteWorker.java;46) ~[server-core-8.5.0.jar:8.5.0]
.........

What you expected to happen

I reviewd [HashCodeSelector#select()] code,

public RemoteClient select(List<RemoteClient> clients, StreamData streamData) {
        int size = clients.size();
        int selectIndex = Math.abs(streamData.remoteHashCode()) % size;
        return clients.get(selectIndex);
    }

find : int selectIndex = Math.abs(streamData.remoteHashCode()) % size;

Maybe streamData.remoteHashCode() = Integer.MIN_VALUE cause selectIndex < 0 。

How to reproduce

I have used skywalking OAP 8.5.0 5 years , just meet this error recently.

Anything else

No response

Are you willing to submit a pull request to fix on your own?

• Yes I am willing to submit a pull request on my own!

Code of Conduct

• I agree to follow this project's Code of Conduct

[wu-sheng]

Which JDK are you running the test on?

I tried

System.out.println(Math.abs(Integer.MIN_VALUE) % 4);

The output is 0. And IDEA also indicated that as a warning before running.

[lihwstudy]

JDK 1.8

[lihwstudy]

I tried :

System.out.println(Math.abs(Integer.MIN_VALUE) % 15);

it's value is -8

[wu-sheng]

I think this should fix your issue. #13171

[lihwstudy]

Thanks.