Modification in Main Action method signature and improved the error log (#2)

* modified action signature and changed example action

* format code

* changed response error message for action loop

* change error msg

* refactored error messages

Author: rdiaz82

rust1.32/src/action_loop/src/main.rs

@@ -12,11 +12,16 @@ use std::{
 
 #[derive(Debug, Clone, PartialEq, Deserialize)]
 struct Input {
-    value: HashMap<String, Value>,
+    value: Value,
     #[serde(flatten)]
     environment: HashMap<String, Value>,
 }
 
+fn log_error(fd3: &mut File, error: Error) {
+    writeln!(fd3, "{{\"error\":\"{}\"}}\n", error).expect("Error writing on fd3");
+    eprintln!("error: {}", error);
+}
+
 fn main() {
     let mut fd3 = unsafe { File::from_raw_fd(3) };
     let stdin = stdin();
@@ -28,17 +33,20 @@ fn main() {
                 for (key, val) in input.environment {
                     env::set_var(format!("__OW_{}", key.to_uppercase()), val.to_string());
                 }
-                match serde_json::to_string(&actionMain(input.value)) {
-                    Ok(result) => {
-                        writeln!(&mut fd3, "{}", result).expect("Error writing on fd3");
-                    }
+                match actionMain(input.value) {
+                    Ok(action_result) => match serde_json::to_string(&action_result) {
+                        Ok(response) => {
+                            writeln!(&mut fd3, "{}", response).expect("Error writing on fd3")
+                        }
+                        Err(err) => log_error(&mut fd3, err),
+                    },
                     Err(err) => {
-                        eprintln!("Error formatting result value json: {}", err);
+                        log_error(&mut fd3, err);
                     }
                 }
             }
             Err(err) => {
-                eprintln!("Error parsing input: {}", err);
+                log_error(&mut fd3, err);
             }
         }
         stdout().flush().expect("Error flushing stdout");

rust1.32/src/actions/Cargo.toml

@@ -2,7 +2,11 @@
 name = "actions"
 version = "0.1.0"
 authors = ["Roberto Diaz <roberto@theagilemonkeys.com>"]
+edition = "2018"
 
 [dependencies]
 serde_json = "1.0"
+serde = "1.0"
+serde_derive = "1.0"
+
 

rust1.32/src/actions/src/lib.rs

@@ -1,10 +1,27 @@
 extern crate serde_json;
 
-use std::collections::HashMap;
-use serde_json::Value;
+use serde_derive::{Deserialize, Serialize};
+use serde_json::{Error, Value};
 
+#[derive(Debug, Clone, PartialEq, Serialize, Deserialize)]
+struct Input {
+    #[serde(default = "stranger")]
+    name: String,
+}
+
+#[derive(Debug, Clone, PartialEq, Serialize, Deserialize)]
+struct Output {
+    greeting: String,
+}
+
+fn stranger() -> String {
+    "stranger".to_string()
+}
 
-pub fn main(mut input_data: HashMap<String, Value>) -> HashMap<String, Value> {
-    input_data.insert("added_key".to_string(),Value::String("test".to_string()));
-    input_data
+pub fn main(args: Value) -> Result<Value, Error> {
+    let input: Input = serde_json::from_value(args)?;
+    let output = Output {
+        greeting: format!("Hello, {}", input.name),
+    };
+    serde_json::to_value(output)
 }