Skip to content

Commit 0296288

Browse files
committed
treewide: silent download, unpack and others
This introduces changes from NuttX commits: 03b164f 7fef3e48e6092a59e58b541ef62bdd5f2f600b61 The only left out is 'Register:' as that provides pretty handly list of applications in the firmware. The download is unified to handle it always the same way.
1 parent 02d293d commit 0296288

File tree

21 files changed

+74
-79
lines changed

21 files changed

+74
-79
lines changed

Makefile

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -139,18 +139,21 @@ HEAD_OBJ += $(wildcard $(APPDIR)$(DELIM)import$(DELIM)startup$(DELIM)*$(OBJEXT))
139139
HEAD_OBJ += $(wildcard $(APPDIR)$(DELIM)builtin$(DELIM)*$(OBJEXT))
140140

141141
.import: $(BIN) install
142-
$(Q) echo "LD: nuttx"
142+
$(ECHO_BEGIN)"LD: nuttx "
143143
$(Q) $(LD) --entry=__start $(LDFLAGS) $(LDLIBPATH) $(EXTRA_LIBPATHS) \
144144
-L$(APPDIR)$(DELIM)import$(DELIM)scripts -T$(LDNAME) \
145145
-o nuttx$(EXEEXT) $(HEAD_OBJ) $(EXTRA_OBJS) $(LDSTARTGROUP) \
146146
$(BIN) $(LDLIBS) $(EXTRA_LIBS) $(LDENDGROUP)
147+
$(ECHO_END)
147148
ifeq ($(CONFIG_INTELHEX_BINARY),y)
148-
$(Q) echo "CP: nuttx.hex"
149+
$(ECHO_BEGIN)"CP: nuttx.hex "
149150
$(Q) $(OBJCOPY) $(OBJCOPYARGS) -O ihex nuttx$(EXEEXT) nuttx.hex
151+
$(ECHO_END)
150152
endif
151153
ifeq ($(CONFIG_RAW_BINARY),y)
152-
$(Q) echo "CP: nuttx.bin"
154+
$(ECHO_BEGIN)"CP: nuttx.bin "
153155
$(Q) $(OBJCOPY) $(OBJCOPYARGS) -O binary nuttx$(EXEEXT) nuttx.bin
156+
$(ECHO_END)
154157
endif
155158
$(call POSTBUILD, $(APPDIR))
156159

boot/mcuboot/Makefile

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@
2121
include $(APPDIR)/Make.defs
2222

2323
MCUBOOT_VERSION := $(patsubst "%",%,$(CONFIG_MCUBOOT_VERSION))
24+
MCUBOOT_URL_BASE = https://github.com/mcu-tools/mcuboot/archive
2425
MCUBOOT_TARBALL = $(MCUBOOT_VERSION).tar.gz
2526
MCUBOOT_UNPACK = mcuboot
2627
MCUBOOT_SRCDIR = $(MCUBOOT_UNPACK)$(DELIM)boot$(DELIM)bootutil$(DELIM)src
@@ -77,14 +78,14 @@ CXXFLAGS += ${INCDIR_PREFIX}mcuboot/ext/tinycrypt/lib/include
7778
endif
7879

7980
$(MCUBOOT_TARBALL):
80-
$(Q) echo "Downloading MCUboot-$(MCUBOOT_VERSION)"
81-
$(Q) curl -O -L https://github.com/mcu-tools/mcuboot/archive/$(MCUBOOT_TARBALL)
81+
$(call DOWNLOAD,$(MCUBOOT_URL_BASE),$(MCUBOOT_TARBALL))
8282

8383
$(MCUBOOT_UNPACK): $(MCUBOOT_TARBALL)
84-
$(Q) echo "Unpacking: $(MCUBOOT_TARBALL) -> $(MCUBOOT_UNPACK)"
84+
$(ECHO_BEGIN)"Unpacking: $(MCUBOOT_TARBALL) -> $(MCUBOOT_UNPACK) "
8585
$(Q) tar zxf $(MCUBOOT_TARBALL)
8686
$(Q) mv mcuboot-$(MCUBOOT_VERSION) $(MCUBOOT_UNPACK)
8787
$(Q) touch $(MCUBOOT_UNPACK)
88+
$(ECHO_END)
8889

8990
# Download and unpack tarball if no git repo found
9091
ifeq ($(wildcard $(MCUBOOT_UNPACK)/.git),)

canutils/lely-canopen/Makefile

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -170,15 +170,16 @@ endif
170170
# Download and unpack tarball if no git repo found
171171
ifeq ($(wildcard $(LELYCANOPEN_SRCNAME)/.git),)
172172
$(LELYCANOPEN_TARBALL):
173-
@echo "Downloading: $(LELYCANOPEN_TARBALL)"
174-
$(Q) curl -L -O $(CONFIG_CANUTILS_LELYCANOPEN_URL)/$(LELYCANOPEN_TARBALL)
173+
$(call DOWNLOAD,$(CONFIG_CANUTILS_LELYCANOPEN_URL),$(LELYCANOPEN_TARBALL))
175174

176175
$(LELYCANOPEN_SRCNAME): $(LELYCANOPEN_TARBALL)
177-
@echo "Unpacking: $(LELYCANOPEN_TARBALL) -> $(LELYCANOPEN_UNPACKNAME)"
176+
$(ECHO_BEGIN)"Unpacking: $(LELYCANOPEN_TARBALL) -> $(LELYCANOPEN_UNPACKNAME) "
178177
$(Q) $(UNPACK) $(LELYCANOPEN_TARBALL)
179178
$(Q) mv $(LELYCANOPEN_UNPACKNAME) $(LELYCANOPEN_SRCNAME)
180-
$(Q) cat 0001-NuttX-port.patch | patch -s -N -d $(LELYCANOPEN_SRCNAME) -p1
181-
$(Q) echo "Patching $(LELYCANOPEN_SRCNAME)"
179+
$(ECHO_END)
180+
$(ECHO_BEGIN)"Patching $(LELYCANOPEN_SRCNAME) "
181+
$(Q) patch -s -N -d $(LELYCANOPEN_SRCNAME) -p1 < 0001-NuttX-port.patch
182+
$(ECHO_END)
182183
endif
183184

184185
context:: $(LELYCANOPEN_SRCNAME)

crypto/libtomcrypt/Makefile

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -464,17 +464,18 @@ endif
464464
endif
465465

466466
$(LIBTOMCRYPT_ZIP):
467-
@echo "Downloading: $(LIBTOMCRYPT_ZIP)"
468-
$(Q) curl -O -L $(CONFIG_LIBTOMCRYPT_URL)/$(LIBTOMCRYPT_ZIP)
467+
$(call DOWNLOAD,$(CONFIG_LIBTOMCRYPT_URL),$(LIBTOMCRYPT_ZIP))
469468

470469
$(LIBTOMCRYPT_UNPACKNAME): $(LIBTOMCRYPT_ZIP)
471-
@echo "Unpacking: $(LIBTOMCRYPT_ZIP) -> $(LIBTOMCRYPT_UNPACKNAME)"
470+
$(ECHO_BEGIN)"Unpacking: $(LIBTOMCRYPT_ZIP) -> $(LIBTOMCRYPT_UNPACKNAME) "
472471
$(Q) $(UNPACK) $(LIBTOMCRYPT_ZIP)
473472
$(Q) mv libtomcrypt-$(LIBTOMCRYPT_VERSION) $(LIBTOMCRYPT_UNPACKNAME)
474-
$(Q) echo "Patching $(LIBTOMCRYPT_UNPACKNAME)"
473+
$(ECHO_END)
474+
$(ECHO_BEGIN)"Patching $(LIBTOMCRYPT_UNPACKNAME) "
475475
$(Q) patch -p0 < digit-bit.patch # Update deprecated macro from ltm
476476
$(Q) patch -p0 < ltcrypt-flush.patch # Missing stdout flush in demo app
477477
$(Q) touch $(LIBTOMCRYPT_UNPACKNAME)
478+
$(ECHO_END)
478479

479480
# Download and unpack tarball if no git repo found
480481
ifeq ($(wildcard $(LIBTOMCRYPT_UNPACKNAME)/.git),)

graphics/lvgl/Makefile

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -95,17 +95,14 @@ LVGL_TARBALL = v$(LVGL_VERSION).zip
9595

9696
LVGL_UNPACKNAME = lvgl
9797
UNPACK ?= unzip -o $(if $(V),,-q)
98-
CURL ?= curl -L -O $(if $(V),,-Ss)
9998

10099
LVGL_UNPACKDIR = $(WD)/$(LVGL_UNPACKNAME)
101100

102101
$(LVGL_TARBALL):
103-
$(ECHO_BEGIN)"Downloading: $(LVGL_TARBALL)"
104-
$(Q) $(CURL) $(CONFIG_GRAPH_LVGL_URL)/$(LVGL_TARBALL)
105-
$(ECHO_END)
102+
$(call DOWNLOAD,$(CONFIG_GRAPH_LVGL_URL),$(LVGL_TARBALL))
106103

107104
$(LVGL_UNPACKNAME): $(LVGL_TARBALL)
108-
$(ECHO_BEGIN)"Unpacking: $(LVGL_TARBALL) -> $(LVGL_UNPACKNAME)"
105+
$(ECHO_BEGIN)"Unpacking: $(LVGL_TARBALL) -> $(LVGL_UNPACKNAME) "
109106
$(Q) $(UNPACK) $(LVGL_TARBALL)
110107
$(Q) mv lvgl-$(LVGL_VERSION) $(LVGL_UNPACKNAME)
111108
$(Q) touch $(LVGL_UNPACKNAME)

industry/scpi/Makefile

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,6 @@ SCPI_VERSION = 2.2
2424
SCPI_UNPACK = scpi-parser
2525
SCPI_TARBALL = v$(SCPI_VERSION).tar.gz
2626
SCPI_URL_BASE = https://github.com/j123b567/scpi-parser/archive/refs/tags
27-
SCPI_URL = $(SCPI_URL_BASE)/$(SCPI_TARBALL)
2827

2928
CSRCS += error.c fifo.c ieee488.c
3029
CSRCS += minimal.c parser.c units.c utils.c
@@ -51,11 +50,11 @@ VPATH += $(SCPI_UNPACK)/examples/common
5150
endif # CONFIG_SCPI_PARSER_DEMO
5251

5352
$(SCPI_TARBALL):
54-
$(Q) echo "Downloading $(SCPI_TARBALL)"
55-
$(Q) curl -O -L $(SCPI_URL)
56-
$(Q) echo "Unpacking $(SCPI_TARBALL) to $(SCPI_UNPACK)"
53+
$(call DOWNLOAD,$(SCPI_URL_BASE),$(SCPI_TARBALL))
54+
$(ECHO_BEGIN)"Unpacking $(SCPI_TARBALL) to $(SCPI_UNPACK) "
5755
$(Q) tar xzvf $(SCPI_TARBALL)
5856
$(Q) mv scpi-parser-$(SCPI_VERSION) $(SCPI_UNPACK)
57+
$(ECHO_END)
5958

6059
# Download and unpack tarball if no git repo found
6160
ifeq ($(wildcard $(SCPI_UNPACK)/.git),)

interpreters/duktape/Makefile

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,6 @@ DUKTAPE_VERSION = 2.5.0
2424
DUKTAPE_UNPACK = duktape
2525
DUKTAPE_TARBALL = duktape-$(DUKTAPE_VERSION).tar.xz
2626
DUKTAPE_URL_BASE = https://github.com/svaarala/duktape/releases/download/
27-
DUKTAPE_URL = $(DUKTAPE_URL_BASE)v$(DUKTAPE_VERSION)/$(DUKTAPE_TARBALL)
2827

2928
CSRCS = duktape.c
3029
CSRCS += duk_console.c
@@ -49,15 +48,16 @@ CFLAGS += -DDUK_CMDLINE_CONSOLE_SUPPORT
4948
CFLAGS += -DDUK_CMDLINE_PRINTALERT_SUPPORT
5049

5150
$(DUKTAPE_TARBALL):
52-
$(Q) echo "Downloading $(DUKTAPE_TARBALL)"
53-
$(Q) curl -O -L $(DUKTAPE_URL)
51+
$(call DOWNLOAD,$(DUKTAPE_URL_BASE),$(DUKTAPE_TARBALL))
5452

5553
$(DUKTAPE_UNPACK): $(DUKTAPE_TARBALL)
56-
$(Q) echo "Unpacking $(DUKTAPE_TARBALL) to $(DUKTAPE_UNPACK)"
54+
$(ECHO_BEGIN)"Unpacking $(DUKTAPE_TARBALL) to $(DUKTAPE_UNPACK) "
5755
$(Q) tar xfJ $(DUKTAPE_TARBALL)
5856
$(Q) mv duktape-$(DUKTAPE_VERSION) $(DUKTAPE_UNPACK)
59-
$(Q) echo "Patching $(DUKTAPE_UNPACK)"
57+
$(ECHO_END)
58+
$(ECHO_BEGIN)"Patching $(DUKTAPE_UNPACK) "
6059
$(Q) patch -p0 < duk_cmdline.patch
60+
$(ECHO_END)
6161

6262
$(DUKTAPE_UNPACK)/.patch: $(DUKTAPE_UNPACK)
6363
$(Q) touch $(DUKTAPE_UNPACK)/.patch

interpreters/lua/Makefile

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,6 @@ LUA_VERSION = $(patsubst "%",%,$(strip $(CONFIG_INTERPRETER_LUA_VERSION)))
3333
LUA_TARBALL = lua-$(LUA_VERSION).tar.gz
3434
LUA_UNPACK = lua-$(LUA_VERSION)
3535
LUA_URL_BASE = http://www.lua.org/ftp
36-
LUA_URL = $(LUA_URL_BASE)/$(LUA_TARBALL)
3736
LUA_SRC = $(LUA_UNPACK)$(DELIM)src
3837

3938
MAINSRC = $(LUA_SRC)$(DELIM)lua.c
@@ -68,10 +67,10 @@ endif
6867
# Lua download and unpack
6968

7069
$(LUA_TARBALL):
71-
$(Q) echo "Downloading $(LUA_TARBALL)"
72-
$(Q) curl -O -L $(LUA_URL)
73-
$(Q) echo "Unpacking $(LUA_TARBALL) to $(LUA_UNPACK)"
70+
$(call DOWNLOAD,$(LUA_URL_BASE),$(LUA_TARBALL))
71+
$(ECHO_BEGIN)"Unpacking $(LUA_TARBALL) to $(LUA_UNPACK) "
7472
$(Q) tar -xvzf $(LUA_TARBALL)
73+
$(ECHO_END)
7574

7675
# Download and unpack tarball if no git repo found
7776
ifeq ($(wildcard $(LUA_UNPACK)/.git),)

interpreters/lua/Module.mk

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,10 +21,12 @@
2121
LUAMOD_REGISTRY = $(APPDIR)$(DELIM)interpreters$(DELIM)lua$(DELIM)registry
2222

2323
define LUAMOD_REGISTER
24-
$(Q) echo Register Lua Module: $1
24+
$(ECHO_BEGIN)"Register Lua Module: $1 "
2525
$(Q) echo { \"$1\", $2 }, > "$(LUAMOD_REGISTRY)$(DELIM)$1.bdat"
26-
$(Q) echo "int $2(lua_State *L);" > "$(LUAMOD_REGISTRY)$(DELIM)$1.pdat"
26+
$(ECHO_END)
27+
$(ECHO_BEGIN)"int $2(lua_State *L);" > "$(LUAMOD_REGISTRY)$(DELIM)$1.pdat "
2728
$(Q) touch "$(LUAMOD_REGISTRY)$(DELIM).updated"
29+
$(ECHO_END)
2830
endef
2931

3032
ifneq ($(LUAMODNAME),)

interpreters/luamodules/cjson/Makefile

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -24,21 +24,20 @@ LUACJSON_VERSION = $(patsubst "%",%,$(strip $(CONFIG_LUA_CJSON_VERSION)))
2424
LUACJSON_TARBALL = $(LUACJSON_VERSION).tar.gz
2525
LUACJSON_UNPACK = lua-cjson
2626
LUACJSON_URL_BASE = https://github.com/openresty/lua-cjson/archive/refs/tags
27-
LUACJSON_URL = $(LUACJSON_URL_BASE)/$(LUACJSON_TARBALL)
2827
LUACJSON_SRC = $(LUACJSON_UNPACK)
2928

3029
VPATH += lua-cjson
3130
CSRCS = lua_cjson.c strbuf.c fpconv.c
3231

3332
$(LUACJSON_TARBALL):
34-
$(Q) echo "Downloading $(LUACJSON_TARBALL) from $(LUACJSON_URL)"
35-
$(Q) curl -O -L $(LUACJSON_URL)
33+
$(call DOWNLOAD,$(LUACJSON_URL_BASE),$(LUACJSON_TARBALL))
3634

3735
$(LUACJSON_UNPACK): $(LUACJSON_TARBALL)
38-
$(Q) echo "Unpacking $(LUACJSON_TARBALL) to $(LUACJSON_UNPACK)"
36+
$(ECHO_BEGIN)"Unpacking $(LUACJSON_TARBALL) to $(LUACJSON_UNPACK) "
3937
$(Q) tar -xvzf $(LUACJSON_TARBALL)
4038
$(Q) mv lua-cjson-$(LUACJSON_VERSION) $(LUACJSON_UNPACK)
4139
$(Q) patch -d $(LUACJSON_UNPACK) -p1 < 0001-fix-compile-warnings.patch
40+
$(ECHO_END)
4241

4342
$(LUACJSON_UNPACK)/.patch: $(LUACJSON_UNPACK)
4443
touch $(LUACJSON_UNPACK)/.patch

0 commit comments

Comments
 (0)