Skip to content

Commit eb0f3d9

Browse files
authored
[BugFix][C++] Remove arrow header from GraphAr's header (#229)
Signed-off-by: acezen <qiaozi.zwb@alibaba-inc.com>
1 parent dacd613 commit eb0f3d9

File tree

5 files changed

+9
-2
lines changed

5 files changed

+9
-2
lines changed

cpp/include/gar/util/filesystem.h

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,6 @@ limitations under the License.
2626
#include "gar/util/status.h"
2727
#include "gar/util/util.h"
2828

29-
#include "arrow/dataset/api.h"
3029
#include "gar/util/reader_util.h"
3130

3231
// forward declarations
@@ -39,6 +38,9 @@ class FileSystem;
3938
namespace io {
4039
class RandomAccessFile;
4140
}
41+
namespace dataset {
42+
class FileFormat;
43+
}
4244
} // namespace arrow
4345

4446
namespace GAR_NAMESPACE_INTERNAL {

cpp/include/gar/util/reader_util.h

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,10 +22,11 @@ limitations under the License.
2222
#include <vector>
2323

2424
#include "gar/graph_info.h"
25-
#include "gar/util/expression.h"
2625

2726
namespace GAR_NAMESPACE_INTERNAL {
2827

28+
class Expression;
29+
2930
namespace util {
3031

3132
using Filter = std::shared_ptr<Expression>;

cpp/src/filesystem.cc

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,10 +16,12 @@ limitations under the License.
1616
#include "arrow/adapters/orc/adapter.h"
1717
#include "arrow/api.h"
1818
#include "arrow/csv/api.h"
19+
#include "arrow/dataset/api.h"
1920
#include "arrow/filesystem/api.h"
2021
#include "arrow/ipc/writer.h"
2122
#include "parquet/arrow/writer.h"
2223

24+
#include "gar/util/expression.h"
2325
#include "gar/util/filesystem.h"
2426

2527
namespace GAR_NAMESPACE_INTERNAL {

cpp/src/reader_util.cc

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@ limitations under the License.
2121
#include "parquet/arrow/reader.h"
2222

2323
#include "gar/graph_info.h"
24+
#include "gar/util/expression.h"
2425
#include "gar/util/filesystem.h"
2526
#include "gar/util/reader_util.h"
2627

cpp/test/test_arrow_chunk_reader.cc

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@ limitations under the License.
1919

2020
#include "./util.h"
2121
#include "gar/reader/arrow_chunk_reader.h"
22+
#include "gar/util/expression.h"
2223

2324
#define CATCH_CONFIG_MAIN
2425
#include <catch2/catch.hpp>

0 commit comments

Comments
 (0)