PR pickup time is considering any comment rather than review comment

[AnkeshThakur]

The PR pickup time calculation in DORA does not account for review comment. It picks any type of comment for calculation. Any automation (CI/bots etc) can comment on the PR and it would consider it to be picked up.

Code -

incubator-devlake/backend/plugins/dora/tasks/change_lead_time_calculator.go

Lines 183 to 191 in e0584d6

	func getFirstReview(prId string, prCreator string, db dal.Dal) (*code.PullRequestComment, errors.Error) {
	// Initialize a review comment object
	review := &code.PullRequestComment{}
	// Define the SQL clauses for the database query
	commentClauses := []dal.Clause{
	dal.From(&code.PullRequestComment{}), // Select from the "pull_request_comments" table
	dal.Where("pull_request_id = ? and account_id != ?", prId, prCreator), // Filter by the PR ID and exclude comments from the PR creator
	dal.Orderby("created_date ASC"), // Order by the created date of the review comments (ascending)
	}

It should filter based on comment type 'REVIEW' and first review comment's timestamp should be used for pickup time calculation. In case there is no review comment, pickup time should be equal to time diff between created_date and merge date.

[klesh]

Make sense, would you like to put up an PR for that?

[AnkeshThakur]

Yes. Sure thing!

[klesh]

Nice, looking forward to it.

[khalibartan]

is this fixed?