Skip to content

Commit 5677d44

Browse files
authored
[easy] Add comment on non-existent namespace/table at drop (#1245)
## What changes are included in this PR? I added documentation on the behavior when table/namespace to drop doesn't exist, which I think it's important to consolidate for traits. I reference `MemoryCatalog` for behavior: https://github.com/apache/iceberg-rust/blob/main/crates/catalog/memory/src/catalog.rs ## Are these changes tested? N/A
1 parent 5592841 commit 5677d44

File tree

1 file changed

+2
-2
lines changed
  • crates/iceberg/src/catalog

1 file changed

+2
-2
lines changed

crates/iceberg/src/catalog/mod.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,7 @@ pub trait Catalog: Debug + Sync + Send {
6767
properties: HashMap<String, String>,
6868
) -> Result<()>;
6969

70-
/// Drop a namespace from the catalog.
70+
/// Drop a namespace from the catalog, or returns error if it doesn't exist.
7171
async fn drop_namespace(&self, namespace: &NamespaceIdent) -> Result<()>;
7272

7373
/// List tables from namespace.
@@ -83,7 +83,7 @@ pub trait Catalog: Debug + Sync + Send {
8383
/// Load table from the catalog.
8484
async fn load_table(&self, table: &TableIdent) -> Result<Table>;
8585

86-
/// Drop a table from the catalog.
86+
/// Drop a table from the catalog, or returns error if it doesn't exist.
8787
async fn drop_table(&self, table: &TableIdent) -> Result<()>;
8888

8989
/// Check if a table exists in the catalog.

0 commit comments

Comments
 (0)