Skip to content

Commit 2f313c9

Browse files
authored
Run dependency license check in release script (#1367)
## Which issue does this PR close? <!-- We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123. --> - Closes #. ## What changes are included in this PR? Adds `python3 ./scripts/dependencies.py check` to the release script. This will check dependencies' licenses. Helps prevent issue like #1345 where the `DEPENDENCIES.rust.tsv` files were accidentally removed Also moved apache license check to the beginning of the release script <!-- Provide a summary of the modifications in this PR. List the main changes such as new features, bug fixes, refactoring, or any other updates. --> ## Are these changes tested? <!-- Specify what test covers (unit test, integration test, etc.). If tests are not included in your PR, please explain why (for example, are they covered by existing tests)? --> Yes, verified by running ``` ICEBERG_VERSION=0.5.0 ICEBERG_VERSION_RC=2 ./scripts/release.sh ```
1 parent 198e5c1 commit 2f313c9

File tree

1 file changed

+9
-4
lines changed

1 file changed

+9
-4
lines changed

scripts/release.sh

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -38,10 +38,19 @@ mkdir -p dist/
3838
echo "> Checkout version branch"
3939
git checkout -B "${git_branch}"
4040

41+
# Run a few checks
42+
echo "> Check license"
43+
docker run -it --rm -v $(pwd):/github/workspace apache/skywalking-eyes header check
44+
45+
echo "> Run dependency license check using cargo-deny"
46+
python3 ./scripts/dependencies.py check
47+
48+
# Generate and verify artifacts
4149
echo "> Start package"
4250
git archive --format=tar.gz --output="dist/apache-iceberg-rust-$release_version-src.tar.gz" --prefix="apache-iceberg-rust-$release_version-src/" --add-file=Cargo.toml "$git_branch"
4351

4452
cd dist
53+
4554
echo "> Generate signature"
4655
for i in *.tar.gz; do
4756
echo "$i"
@@ -62,7 +71,3 @@ for i in *.tar.gz; do
6271
echo "$i"
6372
sha512sum --check "$i.sha512"
6473
done
65-
66-
cd ..
67-
echo "> Check license"
68-
docker run -it --rm -v $(pwd):/github/workspace apache/skywalking-eyes header check

0 commit comments

Comments
 (0)