[HUDI-9638] infer and validate merging table configs for table version 9 #13615
+674
−109
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
size:L
github-actions
bot
added
size:XL
github-actions
bot
added
size:L
linliu-code
changed the title
nsivabalan
reviewed
Jul 26, 2025
hudi-common/src/main/java/org/apache/hudi/common/table/HoodieTableConfig.java
Show resolved
Hide resolved
| * Handle table config creation logic when creating a table for Table Version 9, | ||
| * since it has some different logic from previous versions. | ||
| */ | ||
| public static Map<String, String> inferMergingConfigsForVersion9(RecordMergeMode recordMergeMode, |
There was a problem hiding this comment.
why public?
Also, lets avoid making static methods everywhere. if we can keep it private, lets go for it.
why make every method static
There was a problem hiding this comment.
This is similar to inferCorrectMergingBehavior.
hudi-common/src/main/java/org/apache/hudi/common/table/HoodieTableConfig.java
Outdated
Show resolved
Hide resolved
hudi-common/src/main/java/org/apache/hudi/common/table/HoodieTableConfig.java
Outdated
Show resolved
Hide resolved
hudi-common/src/main/java/org/apache/hudi/common/table/HoodieTableConfig.java
Outdated
Show resolved
Hide resolved
hudi-common/src/main/java/org/apache/hudi/common/table/HoodieTableConfig.java
Outdated
Show resolved
Hide resolved
hudi-common/src/main/java/org/apache/hudi/common/table/HoodieTableMetaClient.java
Show resolved
Hide resolved
danny0405
reviewed
Jul 26, 2025
hudi-common/src/main/java/org/apache/hudi/common/table/read/FileGroupReaderSchemaHandler.java
Outdated
Show resolved
Hide resolved
linliu-code
commented
Jul 26, 2025
hudi-common/src/main/java/org/apache/hudi/common/table/HoodieTableConfig.java
Outdated
Show resolved
Hide resolved
linliu-code
force-pushed
the
HUDI-9638
branch
2 times, most recently
from
b4b52de to
42bfd23
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Logs
During table creation in version 9, the merging properties should be also inferred and validated based on the given input.
We add this logic.
We also check payload class is updated during following data ingestion by comparing payload class with legacy payload class if the payload class is the builtin payload classes. Other merging properties are checked as well.
Impact
Then table configurations will be consistent during upgrade/downgrade, table creation, and data ingestion.
Risk level (write none, low medium or high below)
Medium.
Documentation Update
Describe any necessary documentation update if there is any new feature, config, or user-facing change. If not, put "none".
ticket number here and follow the instruction to make
changes to the website.
Contributor's checklist