Skip to content

Build fails because redundant “git.properties” definition from "pom.xml" #2966

@GangLiCN

Description

@GangLiCN

Describe the bug
There are some redundant “git.properties” definition from "pom.xml" which causes build fail.

To Reproduce

  1. Build the project via:
    mvn clean package -DskipTests

  2. Build fails with below error message:
    java.nio.file.NoSuchFileException: xxx\distribution..\git.properties

Expected behavior
Build should succeeds.

Drill version
1.21.2

Additional context
I've checked "pom.xml" and found the root cause of this issue:

> <configuration>
>               <outputDirectory>${project.build.outputDirectory}</outputDirectory>
>               <resources>
>                 <resource>
>                   <!--suppress UnresolvedMavenProperty -->
>                   <directory>${maven.multiModuleProjectDirectory}</directory>
>                 </resource>
>                     <include>git.properties</include>
>               </resources>
> </configuration>
> 

But, "git.properties" also exist on <exclude>...</exclude>definition, which causes conflict.

> <configuration>
>           <excludes>
>             <!-- Please keep this list sorted. -->
>             <exclude>**/*.accdb</exclude>
>             <exclude>**/*.access_log</exclude>
>             <exclude>**/*.access_log</exclude>
>             <exclude>**/.asf.yaml</exclude>
>             <exclude>**/*.autotools</exclude>
>             <exclude>**/*.avi</exclude>
>             <exclude>**/*.avro</exclude>
>             <exclude>**/.buildpath</exclude>
>             <exclude>**/*.checkstyle</exclude>
>             <exclude>**/.classpath</exclude>
>             <exclude>**/client/*build*/**</exclude>
>             <exclude>**/clientlib/y2038/*.c</exclude> <!-- All the files here should have MIT License -->
>             <exclude>**/clientlib/y2038/*.h</exclude> <!-- All the files here should have MIT License -->
>             <exclude>**/client/tags</exclude>
>             <exclude>**/cmake_install.cmake</exclude>
>             <exclude>**/*.cnf</exclude>
>             <exclude>**/control</exclude>
>             <exclude>**/*.cproject</exclude>
>             <exclude>**/*.css</exclude>
>             <exclude>**/*.csv</exclude>
>             <exclude>**/*.csvh</exclude>
>             <exclude>**/*.csvh-test</exclude>
>             <exclude>**/*.dbf</exclude>
>             <!-- TODO DRILL-4336: try to avoid the need to add this -->
>             <exclude>dependency-reduced-pom.xml</exclude>
>             <exclude>**/*.drill</exclude>
>             <exclude>**/.drill.parquet_metadata</exclude>
>             <exclude>**/*.eps</exclude>
>             **<exclude>**/git.properties</exclude>**
>             ...

So, it's necessary to remove the redundant “git.properties” definition from "<include>...</include>" block.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions