CI: Fix slow join test #16796
Merged
CI: Fix slow join test #16796
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xudong963
approved these changes
Jul 16, 2025
crepererum
approved these changes
Jul 17, 2025
|
Thank you @2010YOUY01 and @xudong963 / @crepererum for the review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
#16443 added one batch size option to UT
join_maintains_right_order, thisbatch_sizeof value2will let the test run over 1 minute.What changes are included in this PR?
Change this
batch_sizeoption to a larger value.Are these changes tested?
I tried
cargo nextestagain, and the related tests can finish under 1s.Are there any user-facing changes?
No