Minor: Make execute_input_stream Accessible for Any Sinking Operators #11449
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
approved these changes
Jul 15, 2024
There was a problem hiding this comment.
Looks good to me. Thanks @berkaysynnada and @ozankabak for the review
BTW one thing that we might consider based on @comphead 's discussion #11375 is if we should put these functions in a module like util: datafusion/physical-plan/src/utils.rs
However nothing else in this crate does so and thus I think this PR follows the pattern of the existing code and so 👍 from me
| @@ -805,6 +805,97 @@ pub fn execute_stream_partitioned( | |||
| Ok(streams) | |||
| } | |||
|
|
|||
| /// Executes an input stream and ensures that the resulting stream adheres to | |||
|
Let's move the code around in a subsequent PR if we think that is useful |
|
Thanks again @berkaysynnada and @ozankabak |
xinlifoobar
pushed a commit
to xinlifoobar/datafusion
that referenced
this pull request
Jul 17, 2024
xinlifoobar
pushed a commit
to xinlifoobar/datafusion
that referenced
this pull request
Jul 18, 2024
wiedld
pushed a commit
to influxdata/arrow-datafusion
that referenced
this pull request
Jul 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
Rationale for this change
Currently, DF does not utilize
execute_input_stream()outside of theDataSinkExecimplementation. However, many downstream users might benefit from such a utility when writing their own sink operators. Therefore, moving it to a broader scope could be helpful.What changes are included in this PR?
The
execute_input_stream()function has been moved from theDataSinkExecimplementation tolib.rsin thephysical_planmodule.Are these changes tested?
Are there any user-facing changes?