diff --git a/cpp/cmake_modules/SetupCxxFlags.cmake b/cpp/cmake_modules/SetupCxxFlags.cmake index fdb28b540e2d2..630209ee682c0 100644 --- a/cpp/cmake_modules/SetupCxxFlags.cmake +++ b/cpp/cmake_modules/SetupCxxFlags.cmake @@ -316,6 +316,7 @@ if("${BUILD_WARNING_LEVEL}" STREQUAL "CHECKIN") set(CXX_COMMON_FLAGS "${CXX_COMMON_FLAGS} -Wno-conversion") set(CXX_COMMON_FLAGS "${CXX_COMMON_FLAGS} -Wno-sign-conversion") set(CXX_COMMON_FLAGS "${CXX_COMMON_FLAGS} -Wdate-time") + set(CXX_COMMON_FLAGS "${CXX_COMMON_FLAGS} -Wignored-qualifiers") set(CXX_COMMON_FLAGS "${CXX_COMMON_FLAGS} -Wimplicit-fallthrough") string(APPEND CXX_ONLY_FLAGS " -Wredundant-move") set(CXX_COMMON_FLAGS "${CXX_COMMON_FLAGS} -Wunused-result") diff --git a/cpp/src/arrow/compute/kernels/scalar_temporal_unary.cc b/cpp/src/arrow/compute/kernels/scalar_temporal_unary.cc index ed4f0c3c8eac8..efa6f9b732187 100644 --- a/cpp/src/arrow/compute/kernels/scalar_temporal_unary.cc +++ b/cpp/src/arrow/compute/kernels/scalar_temporal_unary.cc @@ -193,7 +193,7 @@ struct Year { template T Call(KernelContext*, Arg0 arg, Status*) const { - return static_cast(static_cast( + return static_cast(static_cast( year_month_day(floor(localizer_.template ConvertTimePoint(arg))) .year())); } @@ -211,7 +211,7 @@ struct IsLeapYear { template T Call(KernelContext*, Arg0 arg, Status*) const { - int32_t y = static_cast( + int32_t y = static_cast( year_month_day(floor(localizer_.template ConvertTimePoint(arg))) .year()); return y % 4 == 0 && (y % 100 != 0 || y % 400 == 0); @@ -230,7 +230,7 @@ struct Month { template T Call(KernelContext*, Arg0 arg, Status*) const { - return static_cast(static_cast( + return static_cast(static_cast( year_month_day(floor(localizer_.template ConvertTimePoint(arg))) .month())); } @@ -248,7 +248,7 @@ struct Day { template T Call(KernelContext*, Arg0 arg, Status*) const { - return static_cast(static_cast( + return static_cast(static_cast( year_month_day(floor(localizer_.template ConvertTimePoint(arg))) .day())); } @@ -264,9 +264,9 @@ std::array GetYearMonthDay(int64_t arg, Localizer&& localizer) { const auto t = floor(localizer.template ConvertTimePoint(arg)); const auto ymd = year_month_day(t); - return {static_cast(static_cast(ymd.year())), - static_cast(static_cast(ymd.month())), - static_cast(static_cast(ymd.day()))}; + return {static_cast(static_cast(ymd.year())), + static_cast(static_cast(ymd.month())), + static_cast(static_cast(ymd.day()))}; } template @@ -298,9 +298,9 @@ struct YearMonthDayVisitValueFunction { StructBuilder* struct_builder) { return [=](typename InType::c_type arg) { const auto ymd = GetYearMonthDay(arg, NonZonedLocalizer{}); - field_builders[0]->UnsafeAppend(static_cast(ymd[0])); - field_builders[1]->UnsafeAppend(static_cast(ymd[1])); - field_builders[2]->UnsafeAppend(static_cast(ymd[2])); + field_builders[0]->UnsafeAppend(static_cast(ymd[0])); + field_builders[1]->UnsafeAppend(static_cast(ymd[1])); + field_builders[2]->UnsafeAppend(static_cast(ymd[2])); return struct_builder->Append(); }; } @@ -315,18 +315,18 @@ struct YearMonthDayVisitValueFunction { if (timezone.empty()) { return [=](TimestampType::c_type arg) { const auto ymd = GetYearMonthDay(arg, NonZonedLocalizer{}); - field_builders[0]->UnsafeAppend(static_cast(ymd[0])); - field_builders[1]->UnsafeAppend(static_cast(ymd[1])); - field_builders[2]->UnsafeAppend(static_cast(ymd[2])); + field_builders[0]->UnsafeAppend(static_cast(ymd[0])); + field_builders[1]->UnsafeAppend(static_cast(ymd[1])); + field_builders[2]->UnsafeAppend(static_cast(ymd[2])); return struct_builder->Append(); }; } ARROW_ASSIGN_OR_RAISE(auto tz, LocateZone(timezone)); return [=](TimestampType::c_type arg) { const auto ymd = GetYearMonthDay(arg, ZonedLocalizer{tz}); - field_builders[0]->UnsafeAppend(static_cast(ymd[0])); - field_builders[1]->UnsafeAppend(static_cast(ymd[1])); - field_builders[2]->UnsafeAppend(static_cast(ymd[2])); + field_builders[0]->UnsafeAppend(static_cast(ymd[0])); + field_builders[1]->UnsafeAppend(static_cast(ymd[1])); + field_builders[2]->UnsafeAppend(static_cast(ymd[2])); return struct_builder->Append(); }; }