Skip to content

Commit 5672a37

Browse files
authored
GH-46419: [C++] Remove duplicate declaration and sync arg names on acero test_util_internal functions (#45400)
### Rationale for this change While reviewing code I came across minor inconsistencies. ### What changes are included in this PR? Remove duplicate declarations and rename arguments for match source ### Are these changes tested? No functional changes. No new tests needed. ### Are there any user-facing changes? No. * GitHub Issue: #46419 Authored-by: Rafał Hibner <rafal.hibner@secom.com.pl> Signed-off-by: Raúl Cumplido <raulcumplido@gmail.com>
1 parent ce99d00 commit 5672a37

File tree

1 file changed

+2
-11
lines changed

1 file changed

+2
-11
lines changed

cpp/src/arrow/acero/test_util_internal.h

Lines changed: 2 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -114,23 +114,14 @@ Result<std::vector<std::shared_ptr<ArrayVector>>> ToArrayVectors(
114114
const BatchesWithSchema& batches_with_schema);
115115

116116
Result<std::vector<std::shared_ptr<ExecBatch>>> ToExecBatches(
117-
const BatchesWithSchema& batches);
117+
const BatchesWithSchema& batches_with_schema);
118118

119119
Result<std::vector<std::shared_ptr<RecordBatch>>> ToRecordBatches(
120-
const BatchesWithSchema& batches);
121-
122-
Result<std::shared_ptr<RecordBatchReader>> ToRecordBatchReader(
123120
const BatchesWithSchema& batches_with_schema);
124121

125-
Result<std::vector<std::shared_ptr<ArrayVector>>> ToArrayVectors(
122+
Result<std::shared_ptr<RecordBatchReader>> ToRecordBatchReader(
126123
const BatchesWithSchema& batches_with_schema);
127124

128-
Result<std::vector<std::shared_ptr<ExecBatch>>> ToExecBatches(
129-
const BatchesWithSchema& batches);
130-
131-
Result<std::vector<std::shared_ptr<RecordBatch>>> ToRecordBatches(
132-
const BatchesWithSchema& batches);
133-
134125
Result<std::shared_ptr<Table>> SortTableOnAllFields(const std::shared_ptr<Table>& tab);
135126

136127
void AssertTablesEqualIgnoringOrder(const std::shared_ptr<Table>& exp,

0 commit comments

Comments
 (0)