Skip to content
This repository was archived by the owner on Nov 8, 2023. It is now read-only.

Commit d43cd48

Browse files
andy-shevsuperna9999
authored andcommitted
drm/panel: ili9341: Correct use of device property APIs
It seems driver missed the point of proper use of device property APIs. Correct this by updating headers and calls respectively. Fixes: 5a04227 ("drm/panel: Add ilitek ili9341 panel driver") Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org> Link: https://lore.kernel.org/r/20240425142706.2440113-2-andriy.shevchenko@linux.intel.com Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org> Link: https://patchwork.freedesktop.org/patch/msgid/20240425142706.2440113-2-andriy.shevchenko@linux.intel.com
1 parent a37ef76 commit d43cd48

File tree

2 files changed

+4
-3
lines changed

2 files changed

+4
-3
lines changed

drivers/gpu/drm/panel/Kconfig

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -177,7 +177,7 @@ config DRM_PANEL_ILITEK_IL9322
177177

178178
config DRM_PANEL_ILITEK_ILI9341
179179
tristate "Ilitek ILI9341 240x320 QVGA panels"
180-
depends on OF && SPI
180+
depends on SPI
181181
select DRM_KMS_HELPER
182182
select DRM_GEM_DMA_HELPER
183183
depends on BACKLIGHT_CLASS_DEVICE

drivers/gpu/drm/panel/panel-ilitek-ili9341.c

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,8 +22,9 @@
2222
#include <linux/bitops.h>
2323
#include <linux/delay.h>
2424
#include <linux/gpio/consumer.h>
25+
#include <linux/mod_devicetable.h>
2526
#include <linux/module.h>
26-
#include <linux/of.h>
27+
#include <linux/property.h>
2728
#include <linux/regulator/consumer.h>
2829
#include <linux/spi/spi.h>
2930

@@ -691,7 +692,7 @@ static int ili9341_dpi_probe(struct spi_device *spi, struct gpio_desc *dc,
691692
* Every new incarnation of this display must have a unique
692693
* data entry for the system in this driver.
693694
*/
694-
ili->conf = of_device_get_match_data(dev);
695+
ili->conf = device_get_match_data(dev);
695696
if (!ili->conf) {
696697
dev_err(dev, "missing device configuration\n");
697698
return -ENODEV;

0 commit comments

Comments
 (0)