Skip to content
This repository was archived by the owner on Nov 8, 2023. It is now read-only.

Commit cc86482

Browse files
Sakari AilusHans Verkuil
authored andcommitted
media: mei: csi: Warn less verbosely of a missing device fwnode
The check for having device fwnode was meant to be a sanity check but this also happens if the ACPI DSDT has graph port nodes on sensor device(s) but not on the IVSC device. Use a more meaningful warning message to tell about this. Fixes: 33116eb ("media: ivsc: csi: Use IPU bridge") Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com> Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
1 parent 328af04 commit cc86482

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

drivers/media/pci/intel/ivsc/mei_csi.c

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -680,8 +680,10 @@ static int mei_csi_probe(struct mei_cl_device *cldev,
680680
put_device(&ipu->dev);
681681
if (ret < 0)
682682
return ret;
683-
if (WARN_ON(!dev_fwnode(dev)))
683+
if (!dev_fwnode(dev)) {
684+
dev_err(dev, "mei-csi probed without device fwnode!\n");
684685
return -ENXIO;
686+
}
685687

686688
csi = devm_kzalloc(dev, sizeof(struct mei_csi), GFP_KERNEL);
687689
if (!csi)

0 commit comments

Comments
 (0)