Skip to content
This repository was archived by the owner on Nov 8, 2023. It is now read-only.

Commit c5603e2

Browse files
dougg3gregkh
authored andcommitted
Revert "serial: core: only stop transmit when HW fifo is empty"
This reverts commit 7bfb915. This commit broke pxa and omap-serial, because it inhibited them from calling stop_tx() if their TX FIFOs weren't completely empty. This resulted in these two drivers hanging during transmits because the TX interrupt would stay enabled, and a new TX interrupt would never fire. Cc: stable@vger.kernel.org Fixes: 7bfb915 ("serial: core: only stop transmit when HW fifo is empty") Signed-off-by: Doug Brown <doug@schmorgal.com> Link: https://lore.kernel.org/r/20240606195632.173255-2-doug@schmorgal.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
1 parent a81dbd0 commit c5603e2

File tree

1 file changed

+1
-2
lines changed

1 file changed

+1
-2
lines changed

include/linux/serial_core.h

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -811,8 +811,7 @@ enum UART_TX_FLAGS {
811811
if (pending < WAKEUP_CHARS) { \
812812
uart_write_wakeup(__port); \
813813
\
814-
if (!((flags) & UART_TX_NOSTOP) && pending == 0 && \
815-
__port->ops->tx_empty(__port)) \
814+
if (!((flags) & UART_TX_NOSTOP) && pending == 0) \
816815
__port->ops->stop_tx(__port); \
817816
} \
818817
\

0 commit comments

Comments
 (0)