Skip to content
This repository was archived by the owner on Nov 8, 2023. It is now read-only.

Commit bf18311

Browse files
cloehlerafaeljw
authored andcommitted
cpuidle: menu: Cleanup after loadavg removal
The performance impact of loadavg was removed with commit a7fe519 ("cpuidle: menu: Remove get_loadavg() from the performance multiplier") With only iowait remaining the description can be simplified, remove also the no longer needed includes. Signed-off-by: Christian Loehle <christian.loehle@arm.com> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
1 parent 17c4fc3 commit bf18311

File tree

1 file changed

+5
-12
lines changed
  • drivers/cpuidle/governors

1 file changed

+5
-12
lines changed

drivers/cpuidle/governors/menu.c

Lines changed: 5 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,6 @@
1414
#include <linux/ktime.h>
1515
#include <linux/hrtimer.h>
1616
#include <linux/tick.h>
17-
#include <linux/sched.h>
18-
#include <linux/sched/loadavg.h>
1917
#include <linux/sched/stat.h>
2018
#include <linux/math64.h>
2119

@@ -95,16 +93,11 @@
9593
* state, and thus the less likely a busy CPU will hit such a deep
9694
* C state.
9795
*
98-
* Two factors are used in determing this multiplier:
99-
* a value of 10 is added for each point of "per cpu load average" we have.
100-
* a value of 5 points is added for each process that is waiting for
101-
* IO on this CPU.
102-
* (these values are experimentally determined)
103-
*
104-
* The load average factor gives a longer term (few seconds) input to the
105-
* decision, while the iowait value gives a cpu local instantanious input.
106-
* The iowait factor may look low, but realize that this is also already
107-
* represented in the system load average.
96+
* Currently there is only one value determining the factor:
97+
* 10 points are added for each process that is waiting for IO on this CPU.
98+
* (This value was experimentally determined.)
99+
* Utilization is no longer a factor as it was shown that it never contributed
100+
* significantly to the performance multiplier in the first place.
108101
*
109102
*/
110103

0 commit comments

Comments
 (0)