Skip to content
This repository was archived by the owner on Nov 8, 2023. It is now read-only.

Commit bb19535

Browse files
Abhinav Kumarthierryreding
authored andcommitted
drm/msm: remove python 3.9 dependency for compiling msm
Since commit 5acf491 ("drm/msm: import gen_header.py script from Mesa"), compilation is broken on machines having python versions older than 3.9 due to dependency on argparse.BooleanOptionalAction. Switch to use simple bool for the validate flag to remove the dependency. Fixes: 5acf491 ("drm/msm: import gen_header.py script from Mesa") Signed-off-by: Abhinav Kumar <quic_abhinavk@quicinc.com> Tested-by: Douglas Anderson <dianders@chromium.org> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> Signed-off-by: Thierry Reding <treding@nvidia.com> Link: https://patchwork.freedesktop.org/patch/msgid/20240507230440.3384949-1-quic_abhinavk@quicinc.com
1 parent b62c150 commit bb19535

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

drivers/gpu/drm/msm/registers/gen_header.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -538,7 +538,7 @@ def add_all_usages(self, reg, usages):
538538
self.variants.add(reg.domain)
539539

540540
def do_validate(self, schemafile):
541-
if self.validate == False:
541+
if not self.validate:
542542
return
543543

544544
try:
@@ -948,7 +948,8 @@ def main():
948948
parser = argparse.ArgumentParser()
949949
parser.add_argument('--rnn', type=str, required=True)
950950
parser.add_argument('--xml', type=str, required=True)
951-
parser.add_argument('--validate', action=argparse.BooleanOptionalAction)
951+
parser.add_argument('--validate', default=False, action='store_true')
952+
parser.add_argument('--no-validate', dest='validate', action='store_false')
952953

953954
subparsers = parser.add_subparsers()
954955
subparsers.required = True

0 commit comments

Comments
 (0)