Skip to content
This repository was archived by the owner on Nov 8, 2023. It is now read-only.

Commit ae01e52

Browse files
Tetsuo Handagregkh
authored andcommitted
serial: drop debugging WARN_ON_ONCE() from uart_write()
syzbot is reporting lockdep warning upon int disc = 7; ioctl(open("/dev/ttyS3", O_RDONLY), TIOCSETD, &disc); sequence. Do like what commit 5f1149d ("serial: drop debugging WARN_ON_ONCE() from uart_put_char()") does. Reported-by: syzbot+f78380e4eae53c64125c@syzkaller.appspotmail.com Closes: https://syzkaller.appspot.com/bug?extid=f78380e4eae53c64125c Signed-off-by: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp> Acked-by: Jiri Slaby <jirislaby@kernel.org> Link: https://lore.kernel.org/r/d775ae2d-a2ac-439e-8e2b-134749f60f30@I-love.SAKURA.ne.jp Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
1 parent 7a2e8e3 commit ae01e52

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/tty/serial/serial_core.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -622,7 +622,7 @@ static ssize_t uart_write(struct tty_struct *tty, const u8 *buf, size_t count)
622622
return -EL3HLT;
623623

624624
port = uart_port_lock(state, flags);
625-
if (WARN_ON_ONCE(!state->port.xmit_buf)) {
625+
if (!state->port.xmit_buf) {
626626
uart_port_unlock(port, flags);
627627
return 0;
628628
}

0 commit comments

Comments
 (0)