Skip to content
This repository was archived by the owner on Nov 8, 2023. It is now read-only.

Commit 9182639

Browse files
Perry Yuansuperm1
authored andcommitted
cpufreq: amd-pstate: enable shared memory type CPPC by default
The amd-pstate-epp driver has been implemented and resolves the performance drop issue seen in passive mode for shared memory type CPPC systems. Users who enable the active mode driver will not experience a performance drop compared to the passive mode driver. Therefore, the EPP driver should be loaded by default for shared memory type CPPC system to get better performance. Signed-off-by: Perry Yuan <perry.yuan@amd.com> Reviewed-by: Mario Limonciello <mario.limonciello@amd.com> Link: https://lore.kernel.org/r/c705507cf3ee790e544251cfd897ed11e8e57712.1718811234.git.perry.yuan@amd.com Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
1 parent c9fdaba commit 9182639

File tree

1 file changed

+1
-12
lines changed

1 file changed

+1
-12
lines changed

drivers/cpufreq/amd-pstate.c

Lines changed: 1 addition & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -86,15 +86,6 @@ struct quirk_entry {
8686
u32 lowest_freq;
8787
};
8888

89-
/*
90-
* TODO: We need more time to fine tune processors with shared memory solution
91-
* with community together.
92-
*
93-
* There are some performance drops on the CPU benchmarks which reports from
94-
* Suse. We are co-working with them to fine tune the shared memory solution. So
95-
* we disable it by default to go acpi-cpufreq on these processors and add a
96-
* module parameter to be able to enable it manually for debugging.
97-
*/
9889
static struct cpufreq_driver *current_pstate_driver;
9990
static struct cpufreq_driver amd_pstate_driver;
10091
static struct cpufreq_driver amd_pstate_epp_driver;
@@ -1815,11 +1806,9 @@ static int __init amd_pstate_init(void)
18151806
/* Disable on the following configs by default:
18161807
* 1. Undefined platforms
18171808
* 2. Server platforms
1818-
* 3. Shared memory designs
18191809
*/
18201810
if (amd_pstate_acpi_pm_profile_undefined() ||
1821-
amd_pstate_acpi_pm_profile_server() ||
1822-
!cpu_feature_enabled(X86_FEATURE_CPPC)) {
1811+
amd_pstate_acpi_pm_profile_server()) {
18231812
pr_info("driver load is disabled, boot with specific mode to enable this\n");
18241813
return -ENODEV;
18251814
}

0 commit comments

Comments
 (0)