Skip to content
This repository was archived by the owner on Nov 8, 2023. It is now read-only.

Commit 7fae6f8

Browse files
committed
Merge branches 'pm-cpuidle' and 'pm-powercap'
Merge cpuidle and power capping changes for 6.11-rc1: - Improve the teo cpuidle governor and clean up leftover comments from the menu cpuidle governor (Christian Loehle). - Clean up a comment typo in the teo cpuidle governor (Atul Kumar Pant). - Add missing MODULE_DESCRIPTION() macro to cpuidle haltpoll (Jeff Johnson). - Switch the intel_idle driver to new Intel CPU model defines (Tony Luck). - Switch the Intel RAPL driver new Intel CPU model defines (Tony Luck). - Simplify if condition in the idle_inject driver (Thorsten Blum). * pm-cpuidle: cpuidle: teo: Don't count non-existent intercepts cpuidle: teo: Remove recent intercepts metric Revert: "cpuidle: teo: Introduce util-awareness" cpuidle: governors: teo: Fix a typo in a comment cpuidle: haltpoll: add missing MODULE_DESCRIPTION() macro cpuidle: menu: Cleanup after loadavg removal intel_idle: Switch to new Intel CPU model defines * pm-powercap: powercap: idle_inject: Simplify if condition powercap: intel_rapl: Switch to new Intel CPU model defines powercap: intel_rapl_msr: Switch to new Intel CPU model defines
3 parents a18abb8 + 4b20b07 + e5753da commit 7fae6f8

File tree

7 files changed

+158
-308
lines changed

7 files changed

+158
-308
lines changed

drivers/cpuidle/cpuidle-haltpoll.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -141,5 +141,6 @@ static void __exit haltpoll_exit(void)
141141

142142
module_init(haltpoll_init);
143143
module_exit(haltpoll_exit);
144+
MODULE_DESCRIPTION("cpuidle driver for haltpoll governor");
144145
MODULE_LICENSE("GPL");
145146
MODULE_AUTHOR("Marcelo Tosatti <mtosatti@redhat.com>");

drivers/cpuidle/governors/menu.c

Lines changed: 5 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,6 @@
1414
#include <linux/ktime.h>
1515
#include <linux/hrtimer.h>
1616
#include <linux/tick.h>
17-
#include <linux/sched.h>
18-
#include <linux/sched/loadavg.h>
1917
#include <linux/sched/stat.h>
2018
#include <linux/math64.h>
2119

@@ -95,16 +93,11 @@
9593
* state, and thus the less likely a busy CPU will hit such a deep
9694
* C state.
9795
*
98-
* Two factors are used in determing this multiplier:
99-
* a value of 10 is added for each point of "per cpu load average" we have.
100-
* a value of 5 points is added for each process that is waiting for
101-
* IO on this CPU.
102-
* (these values are experimentally determined)
103-
*
104-
* The load average factor gives a longer term (few seconds) input to the
105-
* decision, while the iowait value gives a cpu local instantanious input.
106-
* The iowait factor may look low, but realize that this is also already
107-
* represented in the system load average.
96+
* Currently there is only one value determining the factor:
97+
* 10 points are added for each process that is waiting for IO on this CPU.
98+
* (This value was experimentally determined.)
99+
* Utilization is no longer a factor as it was shown that it never contributed
100+
* significantly to the performance multiplier in the first place.
108101
*
109102
*/
110103

0 commit comments

Comments
 (0)