Skip to content
This repository was archived by the owner on Nov 8, 2023. It is now read-only.

Commit 74b38cd

Browse files
Neha Malcom Francisbroonie
authored andcommitted
regulator: tps6594-regulator: Correct multi-phase configuration
According to the TPS6594 PMIC Manual (linked) 8.3.2.1.4 Multi-Phase BUCK Regulator Configurations section, the PMIC ignores all the other bucks' except the primary buck's regulator registers. This is BUCK1 for configurations BUCK12, BUCK123 and BUCK1234 while it is BUCK3 for BUCK34. Correct the registers mapped for these configurations accordingly. Fixes: f17ccc5 ("regulator: tps6594-regulator: Add driver for TI TPS6594 regulators") Link: https://www.ti.com/lit/gpn/tps6594-q1 Signed-off-by: Neha Malcom Francis <n-francis@ti.com> Link: https://msgid.link/r/20240521094758.2190331-1-n-francis@ti.com Signed-off-by: Mark Brown <broonie@kernel.org>
1 parent 1ace99d commit 74b38cd

File tree

1 file changed

+8
-8
lines changed

1 file changed

+8
-8
lines changed

drivers/regulator/tps6594-regulator.c

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -287,30 +287,30 @@ static struct tps6594_regulator_irq_type *tps6594_ldos_irq_types[] = {
287287
static const struct regulator_desc multi_regs[] = {
288288
TPS6594_REGULATOR("BUCK12", "buck12", TPS6594_BUCK_1,
289289
REGULATOR_VOLTAGE, tps6594_bucks_ops, TPS6594_MASK_BUCKS_VSET,
290-
TPS6594_REG_BUCKX_VOUT_1(1),
290+
TPS6594_REG_BUCKX_VOUT_1(0),
291291
TPS6594_MASK_BUCKS_VSET,
292-
TPS6594_REG_BUCKX_CTRL(1),
292+
TPS6594_REG_BUCKX_CTRL(0),
293293
TPS6594_BIT_BUCK_EN, 0, 0, bucks_ranges,
294294
4, 4000, 0, NULL, 0, 0),
295295
TPS6594_REGULATOR("BUCK34", "buck34", TPS6594_BUCK_3,
296296
REGULATOR_VOLTAGE, tps6594_bucks_ops, TPS6594_MASK_BUCKS_VSET,
297-
TPS6594_REG_BUCKX_VOUT_1(3),
297+
TPS6594_REG_BUCKX_VOUT_1(2),
298298
TPS6594_MASK_BUCKS_VSET,
299-
TPS6594_REG_BUCKX_CTRL(3),
299+
TPS6594_REG_BUCKX_CTRL(2),
300300
TPS6594_BIT_BUCK_EN, 0, 0, bucks_ranges,
301301
4, 0, 0, NULL, 0, 0),
302302
TPS6594_REGULATOR("BUCK123", "buck123", TPS6594_BUCK_1,
303303
REGULATOR_VOLTAGE, tps6594_bucks_ops, TPS6594_MASK_BUCKS_VSET,
304-
TPS6594_REG_BUCKX_VOUT_1(1),
304+
TPS6594_REG_BUCKX_VOUT_1(0),
305305
TPS6594_MASK_BUCKS_VSET,
306-
TPS6594_REG_BUCKX_CTRL(1),
306+
TPS6594_REG_BUCKX_CTRL(0),
307307
TPS6594_BIT_BUCK_EN, 0, 0, bucks_ranges,
308308
4, 4000, 0, NULL, 0, 0),
309309
TPS6594_REGULATOR("BUCK1234", "buck1234", TPS6594_BUCK_1,
310310
REGULATOR_VOLTAGE, tps6594_bucks_ops, TPS6594_MASK_BUCKS_VSET,
311-
TPS6594_REG_BUCKX_VOUT_1(1),
311+
TPS6594_REG_BUCKX_VOUT_1(0),
312312
TPS6594_MASK_BUCKS_VSET,
313-
TPS6594_REG_BUCKX_CTRL(1),
313+
TPS6594_REG_BUCKX_CTRL(0),
314314
TPS6594_BIT_BUCK_EN, 0, 0, bucks_ranges,
315315
4, 4000, 0, NULL, 0, 0),
316316
};

0 commit comments

Comments
 (0)