Skip to content
This repository was archived by the owner on Nov 8, 2023. It is now read-only.

Commit 5aca325

Browse files
Uwe Kleine-Königrichardweinberger
authored andcommitted
um: rtc: Convert to platform remove callback returning void
The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Reviewed-by: Geert Uytterhoeven <geert@linux-m68k.org> Signed-off-by: Richard Weinberger <richard@nod.at>
1 parent 470dbef commit 5aca325

File tree

1 file changed

+2
-3
lines changed

1 file changed

+2
-3
lines changed

arch/um/drivers/rtc_kern.c

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -168,16 +168,15 @@ static int uml_rtc_probe(struct platform_device *pdev)
168168
return err;
169169
}
170170

171-
static int uml_rtc_remove(struct platform_device *pdev)
171+
static void uml_rtc_remove(struct platform_device *pdev)
172172
{
173173
device_init_wakeup(&pdev->dev, 0);
174174
uml_rtc_cleanup();
175-
return 0;
176175
}
177176

178177
static struct platform_driver uml_rtc_driver = {
179178
.probe = uml_rtc_probe,
180-
.remove = uml_rtc_remove,
179+
.remove_new = uml_rtc_remove,
181180
.driver = {
182181
.name = "uml-rtc",
183182
},

0 commit comments

Comments
 (0)