Skip to content
This repository was archived by the owner on Nov 8, 2023. It is now read-only.

Commit 32a0bb7

Browse files
committed
Merge tag 'drm-misc-next-fixes-2024-05-23' of https://gitlab.freedesktop.org/drm/misc/kernel into drm-next
drm-misc-next-fixes for v6.10-rc1: - MST null deref fix. - Don't let next bridge create connector in adv7511 to make probe work. Signed-off-by: Dave Airlie <airlied@redhat.com> From: Maarten Lankhorst <maarten.lankhorst@linux.intel.com> Link: https://patchwork.freedesktop.org/patch/msgid/f171b14a-ed6b-4124-893b-802a336dbe2b@linux.intel.com
2 parents c99eb9c + 5a507b7 commit 32a0bb7

File tree

6 files changed

+6
-8
lines changed

6 files changed

+6
-8
lines changed

drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_helpers.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -363,7 +363,7 @@ void dm_helpers_dp_mst_send_payload_allocation(
363363
mst_state = to_drm_dp_mst_topology_state(mst_mgr->base.state);
364364
new_payload = drm_atomic_get_mst_payload_state(mst_state, aconnector->mst_output_port);
365365

366-
ret = drm_dp_add_payload_part2(mst_mgr, mst_state->base.state, new_payload);
366+
ret = drm_dp_add_payload_part2(mst_mgr, new_payload);
367367

368368
if (ret) {
369369
amdgpu_dm_set_mst_status(&aconnector->mst_status,

drivers/gpu/drm/bridge/adv7511/adv7511_drv.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -953,7 +953,8 @@ static int adv7511_bridge_attach(struct drm_bridge *bridge,
953953
int ret = 0;
954954

955955
if (adv->next_bridge) {
956-
ret = drm_bridge_attach(bridge->encoder, adv->next_bridge, bridge, flags);
956+
ret = drm_bridge_attach(bridge->encoder, adv->next_bridge, bridge,
957+
flags | DRM_BRIDGE_ATTACH_NO_CONNECTOR);
957958
if (ret)
958959
return ret;
959960
}

drivers/gpu/drm/display/drm_dp_mst_topology.c

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3421,7 +3421,6 @@ EXPORT_SYMBOL(drm_dp_remove_payload_part2);
34213421
/**
34223422
* drm_dp_add_payload_part2() - Execute payload update part 2
34233423
* @mgr: Manager to use.
3424-
* @state: The global atomic state
34253424
* @payload: The payload to update
34263425
*
34273426
* If @payload was successfully assigned a starting time slot by drm_dp_add_payload_part1(), this
@@ -3430,14 +3429,13 @@ EXPORT_SYMBOL(drm_dp_remove_payload_part2);
34303429
* Returns: 0 on success, negative error code on failure.
34313430
*/
34323431
int drm_dp_add_payload_part2(struct drm_dp_mst_topology_mgr *mgr,
3433-
struct drm_atomic_state *state,
34343432
struct drm_dp_mst_atomic_payload *payload)
34353433
{
34363434
int ret = 0;
34373435

34383436
/* Skip failed payloads */
34393437
if (payload->payload_allocation_status != DRM_DP_MST_PAYLOAD_ALLOCATION_DFP) {
3440-
drm_dbg_kms(state->dev, "Part 1 of payload creation for %s failed, skipping part 2\n",
3438+
drm_dbg_kms(mgr->dev, "Part 1 of payload creation for %s failed, skipping part 2\n",
34413439
payload->port->connector->name);
34423440
return -EIO;
34433441
}

drivers/gpu/drm/i915/display/intel_dp_mst.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1241,7 +1241,7 @@ static void intel_mst_enable_dp(struct intel_atomic_state *state,
12411241
if (first_mst_stream)
12421242
intel_ddi_wait_for_fec_status(encoder, pipe_config, true);
12431243

1244-
drm_dp_add_payload_part2(&intel_dp->mst_mgr, &state->base,
1244+
drm_dp_add_payload_part2(&intel_dp->mst_mgr,
12451245
drm_atomic_get_mst_payload_state(mst_state, connector->port));
12461246

12471247
if (DISPLAY_VER(dev_priv) >= 12)

drivers/gpu/drm/nouveau/dispnv50/disp.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -915,7 +915,7 @@ nv50_msto_cleanup(struct drm_atomic_state *state,
915915
msto->disabled = false;
916916
drm_dp_remove_payload_part2(mgr, new_mst_state, old_payload, new_payload);
917917
} else if (msto->enabled) {
918-
drm_dp_add_payload_part2(mgr, state, new_payload);
918+
drm_dp_add_payload_part2(mgr, new_payload);
919919
msto->enabled = false;
920920
}
921921
}

include/drm/display/drm_dp_mst_helper.h

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -871,7 +871,6 @@ int drm_dp_add_payload_part1(struct drm_dp_mst_topology_mgr *mgr,
871871
struct drm_dp_mst_topology_state *mst_state,
872872
struct drm_dp_mst_atomic_payload *payload);
873873
int drm_dp_add_payload_part2(struct drm_dp_mst_topology_mgr *mgr,
874-
struct drm_atomic_state *state,
875874
struct drm_dp_mst_atomic_payload *payload);
876875
void drm_dp_remove_payload_part1(struct drm_dp_mst_topology_mgr *mgr,
877876
struct drm_dp_mst_topology_state *mst_state,

0 commit comments

Comments
 (0)