Skip to content
This repository was archived by the owner on Nov 8, 2023. It is now read-only.

Commit 31894d3

Browse files
committed
kconfig: remove redundant check in expr_join_or()
The check for 'sym1 == sym2' is redundant here because it has already been done a few lines above: if (sym1 != sym2) return NULL; Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
1 parent aabdc96 commit 31894d3

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

scripts/kconfig/expr.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -476,7 +476,7 @@ static struct expr *expr_join_or(struct expr *e1, struct expr *e2)
476476
return expr_alloc_comp(E_UNEQUAL, sym1, &symbol_yes);
477477
}
478478
}
479-
if (sym1->type == S_BOOLEAN && sym1 == sym2) {
479+
if (sym1->type == S_BOOLEAN) {
480480
if ((e1->type == E_NOT && e1->left.expr->type == E_SYMBOL && e2->type == E_SYMBOL) ||
481481
(e2->type == E_NOT && e2->left.expr->type == E_SYMBOL && e1->type == E_SYMBOL))
482482
return expr_alloc_symbol(&symbol_yes);

0 commit comments

Comments
 (0)