Merge pull request #2 from aochoae/develop

Luhn algorithm

Author: aochoae

.circleci/config.yml

@@ -0,0 +1,32 @@
+# This config was automatically generated from your source code
+# Stacks detected: deps:php:.
+version: 2.1
+orbs:
+  php: circleci/php@1
+jobs:
+  test-php:
+    # Install php packages and run tests
+    docker:
+      - image: cimg/php:8.2.7-node
+    steps:
+      - checkout
+      - php/install-packages
+      - run:
+          name: run tests
+          command: ./vendor/bin/phpunit
+  deploy:
+    # This is an example deploy job, not actually used by the workflow
+    docker:
+      - image: cimg/base:stable
+    steps:
+      # Replace this with steps to deploy to users
+      - run:
+          name: deploy
+          command: '#e.g. ./deploy.sh'
+workflows:
+  build-and-test:
+    jobs:
+      - test-php
+    # - deploy:
+    #     requires:
+    #       - test-php

.travis.yml

@@ -1,5 +1,4 @@
 # Check digit algorithms
-[![Build Status](https://app.travis-ci.com/aochoae/checkdigit-algorithms-php.svg?branch=main)](https://app.travis-ci.com/aochoae/checkdigit-algorithms-php)
 
 Algorithms:
 
@@ -26,6 +25,6 @@ Algorithms:
 
 ## License
 
-Copyright 2021 Luis A. Ochoa
+Copyright 2021, 2024 Luis A. Ochoa
 
 See [LICENSE](LICENSE) for the full license text.

README.md

@@ -1,7 +1,7 @@
 {
     "name": "luisalberto/checkdigit-algorithms",
     "description": "Check Digit Algorithms",
-    "version": "1.0.0",
+    "version": "1.0.1",
     "type": "library",
     "keywords": [
         "damm-algorithm",

composer.json

@@ -1,6 +1,6 @@
 <?php
 /**
- * @copyright Copyright (c) Luis A. Ochoa
+ * @copyright Copyright (c) 2021 Luis A. Ochoa
  * @since     1.0.0
  * @license   https://opensource.org/licenses/MIT MIT License
  */

src/CheckDigitInterface.php

@@ -1,6 +1,6 @@
 <?php
 /**
- * @copyright Copyright (c) Luis A. Ochoa
+ * @copyright Copyright (c) 2021 Luis A. Ochoa
  * @since     1.0.0
  * @license   https://opensource.org/licenses/MIT MIT License
  */

src/CheckDigitTrait.php

@@ -1,6 +1,6 @@
 <?php
 /**
- * @copyright Copyright (c) Luis A. Ochoa
+ * @copyright Copyright (c) 2021 Luis A. Ochoa
  * @since     1.0.0
  * @license   https://opensource.org/licenses/MIT MIT License
  */

src/DammCheckDigit.php

@@ -1,6 +1,6 @@
 <?php
 /**
- * @copyright Copyright (c) Luis A. Ochoa
+ * @copyright Copyright (c) 2021, 2024 Luis A. Ochoa
  * @since     1.0.0
  * @license   https://opensource.org/licenses/MIT MIT License
  */
@@ -52,10 +52,10 @@ public function isValid(string $sequence)
      */
     private function compute(array $sequence)
     {
-        $newSequence = [];
+        $newSequence = $sequence;
 
-        for ($i = 0; $i < count($sequence); $i++) {
-            $newSequence[$i] = ($i % 2 === 0) ? self::SUBSTITUTE[$sequence[$i]] : $sequence[$i];
+        for ($i = count($sequence) - 1; $i >= 0; $i -= 2) {
+            $newSequence[$i] = self::SUBSTITUTE[$sequence[$i]];
         }
 
         $summation = array_sum($newSequence);

src/LuhnCheckDigit.php

@@ -1,6 +1,6 @@
 <?php
 /**
- * @copyright Copyright (c) Luis A. Ochoa
+ * @copyright Copyright (c) 2021 Luis A. Ochoa
  * @since     1.0.0
  * @license   https://opensource.org/licenses/MIT MIT License
  */

src/VerhoeffCheckDigit.php

@@ -1,6 +1,6 @@
 <?php
 /**
- * @copyright Copyright (c) Luis A. Ochoa
+ * @copyright Copyright (c) 2021 Luis A. Ochoa
  * @since     1.0.0
  * @license   https://opensource.org/licenses/MIT MIT License
  */