feat(all): remove eslint-plugin-prettier

Author: yenbekbay

.eslintrc.js

@@ -1,3 +1,3 @@
 module.exports = {
-  extends: ['@anvilabs/eslint-config', '@anvilabs/eslint-config/es5'],
+  extends: ['@anvilabs/eslint-config', '@anvilabs/eslint-config/script'],
 };

.vscode/settings.json

@@ -12,7 +12,5 @@
   "files.autoSave": "off",
   "files.exclude": {
     ".eslintcache": true
-  },
-
-  "prettier.disableLanguages": ["javascript"]
+  }
 }

package.json

@@ -31,13 +31,13 @@
     "{*.json,.vscode/*.json,packages/*/*.json}": ["yarn run format", "git add"]
   },
   "jest": {
-    "roots": ["<rootDir>/packages/eslint-config/rules/"],
+    "roots": ["<rootDir>/packages"],
     "testEnvironment": "node",
     "testRegex": "/__tests__/.+-test\\.js$"
   },
   "devDependencies": {
     "@anvilabs/commitlint-config": "^1.0.0",
-    "@anvilabs/eslint-config": "file:./packages/eslint-config",
+    "@anvilabs/eslint-config": "0.0.0-development",
     "@commitlint/cli": "^6.1.3",
     "eslint": "^4.19.1",
     "husky": "^0.14.3",

packages/eslint-config-typescript/index.js

@@ -43,21 +43,6 @@ module.exports = {
     ],
     'import/no-named-as-default-member': 'off', // conflicts with typescript
     'import/no-named-as-default': 'off', // conflicts with typescript
-    // https://github.com/not-an-aardvark/eslint-plugin-prettier
-    'prettier/prettier': [
-      'error',
-      {
-        useTabs: false,
-        printWidth: 80,
-        tabWidth: 2,
-        singleQuote: true,
-        trailingComma: 'all',
-        bracketSpacing: false,
-        jsxBracketSameLine: false,
-        parser: 'typescript',
-        semi: true,
-      },
-    ],
     // https://github.com/nzakas/eslint-plugin-typescript
     'typescript/adjacent-overload-signatures': 'error',
     'typescript/class-name-casing': 'error',

packages/eslint-config/README.md

@@ -4,7 +4,7 @@
 [![Dependency Status](https://david-dm.org/anvilabs/eslint-config/status.svg?path=packages/eslint-config)](https://david-dm.org/anvilabs/eslint-config?path=packages/eslint-config)
 [![devDependency Status](https://david-dm.org/anvilabs/eslint-config/dev-status.svg?path=packages/eslint-config)](https://david-dm.org/anvilabs/eslint-config?path=packages/eslint-config&type=dev)
 
-Anvilabs' base ESLint config. Makes use of [prettier](https://github.com/jlongster/prettier) for formatting.
+Anvilabs' base ESLint config. Intended to be used together with [prettier](https://github.com/jlongster/prettier).
 
 ## Usage
 
@@ -72,10 +72,6 @@ Available configs include:
 - `'@anvilabs/eslint-config/lodash'` for [Lodash](https://lodash.com/) related rules
 - `'@anvilabs/eslint-config/script'` for usage with config files or scripts
 
-### Things to know
-
-- Running ESLint will report an error if your code does not match prettier style. The rule is autofixable – if you run ESLint with the `--fix` flag, your code will be formatted according to prettier style.
-
 ## License
 
 [MIT License](../../LICENSE) © Anvilabs LLC

packages/eslint-config/es5.js

@@ -1,12 +1,6 @@
 module.exports = {
   extends: ['airbnb-base', 'prettier'],
-  plugins: [
-    'eslint-comments',
-    'no-use-extend-native',
-    'prettier',
-    'promise',
-    'unicorn',
-  ],
+  plugins: ['eslint-comments', 'no-use-extend-native', 'promise', 'unicorn'],
   rules: {
     // http://eslint.org/docs/rules
     'no-warning-comments': [
@@ -70,21 +64,6 @@ module.exports = {
     'import/prefer-default-export': 'off',
     // https://github.com/dustinspecker/eslint-plugin-no-use-extend-native
     'no-use-extend-native/no-use-extend-native': 'error',
-    // https://github.com/not-an-aardvark/eslint-plugin-prettier
-    'prettier/prettier': [
-      'error',
-      {
-        useTabs: false,
-        printWidth: 80,
-        tabWidth: 2,
-        singleQuote: true,
-        trailingComma: 'all',
-        bracketSpacing: false,
-        jsxBracketSameLine: false,
-        parser: 'babylon',
-        semi: true,
-      },
-    ],
     // https://github.com/xjamundx/eslint-plugin-promise
     'promise/always-return': 'error',
     'promise/avoid-new': 'off',

packages/eslint-config/index.js

@@ -2,13 +2,7 @@
   "name": "@anvilabs/eslint-config",
   "version": "0.0.0-development",
   "description": "Anvilabs' base ESLint config",
-  "keywords": [
-    "eslint",
-    "eslint config",
-    "config",
-    "anvilabs",
-    "styleguide"
-  ],
+  "keywords": ["eslint", "eslint config", "config", "anvilabs", "styleguide"],
   "repository": "anvilabs/eslint-config",
   "homepage": "https://github.com/anvilabs/eslint-config#readme",
   "bugs": {
@@ -27,9 +21,11 @@
   "scripts": {
     "find-new-rules:babel": "eslint-find-rules --unused test/fixtures/babel.js",
     "find-new-rules:base": "eslint-find-rules --unused index.js",
-    "find-new-rules:flowtype": "eslint-find-rules --unused test/fixtures/flowtype.js",
+    "find-new-rules:flowtype":
+      "eslint-find-rules --unused test/fixtures/flowtype.js",
     "find-new-rules:jest": "eslint-find-rules --unused test/fixtures/jest.js",
-    "find-new-rules:lodash": "eslint-find-rules --unused test/fixtures/lodash.js",
+    "find-new-rules:lodash":
+      "eslint-find-rules --unused test/fixtures/lodash.js",
     "find-new-rules": "run-p --silent find-new-rules:*",
     "semantic-release": "semantic-release"
   },
@@ -52,7 +48,6 @@
     "eslint-plugin-jest": "^21.15.0",
     "eslint-plugin-lodash-fp": "^2.1.3",
     "eslint-plugin-no-use-extend-native": "^0.3.12",
-    "eslint-plugin-prettier": "^2.6.0",
     "eslint-plugin-promise": "^3.7.0",
     "eslint-plugin-unicorn": "^4.0.2"
   },

packages/eslint-config/package.json

@@ -1,16 +1,7 @@
-const baseConfig = require('.');
-
 // primarily used for config files in the root or in scripts
 module.exports = {
   rules: {
     'global-require': 'off',
-    // https://github.com/prettier/eslint-plugin-prettier
-    'prettier/prettier': [
-      'error',
-      Object.assign({}, baseConfig.rules['prettier/prettier'][1], {
-        trailingComma: 'es5',
-      }),
-    ],
     // https://github.com/benmosher/eslint-plugin-import
     'import/no-extraneous-dependencies': 'off',
     'import/no-internal-modules': 'off',

packages/eslint-config/script.js

@@ -9,24 +9,6 @@
     "@commitlint/config-conventional" "^6.0.4"
     lodash.merge "^4.6.0"
 
-"@anvilabs/eslint-config@file:./packages/eslint-config":
-  version "0.0.0-development"
-  dependencies:
-    babel-eslint "^8.2.2"
-    eslint-config-airbnb-base "^12.1.0"
-    eslint-config-prettier "^2.9.0"
-    eslint-import-resolver-babel-module "^4.0.0"
-    eslint-plugin-babel "^4.1.2"
-    eslint-plugin-eslint-comments "^2.0.2"
-    eslint-plugin-flowtype "^2.46.1"
-    eslint-plugin-import "2.8.0"
-    eslint-plugin-jest "^21.15.0"
-    eslint-plugin-lodash-fp "^2.1.3"
-    eslint-plugin-no-use-extend-native "^0.3.12"
-    eslint-plugin-prettier "^2.6.0"
-    eslint-plugin-promise "^3.7.0"
-    eslint-plugin-unicorn "^4.0.2"
-
 "@babel/code-frame@7.0.0-beta.42", "@babel/code-frame@^7.0.0-beta.35", "@babel/code-frame@^7.0.0-beta.40":
   version "7.0.0-beta.42"
   resolved "https://registry.yarnpkg.com/@babel/code-frame/-/code-frame-7.0.0-beta.42.tgz#a9c83233fa7cd06b39dc77adbb908616ff4f1962"
@@ -1829,13 +1811,6 @@ eslint-plugin-no-use-extend-native@^0.3.12:
     is-obj-prop "^1.0.0"
     is-proto-prop "^1.0.0"
 
-eslint-plugin-prettier@^2.6.0:
-  version "2.6.0"
-  resolved "https://registry.yarnpkg.com/eslint-plugin-prettier/-/eslint-plugin-prettier-2.6.0.tgz#33e4e228bdb06142d03c560ce04ec23f6c767dd7"
-  dependencies:
-    fast-diff "^1.1.1"
-    jest-docblock "^21.0.0"
-
 eslint-plugin-promise@^3.7.0:
   version "3.7.0"
   resolved "https://registry.yarnpkg.com/eslint-plugin-promise/-/eslint-plugin-promise-3.7.0.tgz#f4bde5c2c77cdd69557a8f69a24d1ad3cfc9e67e"
@@ -2144,10 +2119,6 @@ fast-deep-equal@^1.0.0:
   version "1.1.0"
   resolved "https://registry.yarnpkg.com/fast-deep-equal/-/fast-deep-equal-1.1.0.tgz#c053477817c86b51daa853c81e059b733d023614"
 
-fast-diff@^1.1.1:
-  version "1.1.2"
-  resolved "https://registry.yarnpkg.com/fast-diff/-/fast-diff-1.1.2.tgz#4b62c42b8e03de3f848460b639079920695d0154"
-
 fast-glob@^2.0.2:
   version "2.2.0"
   resolved "https://registry.yarnpkg.com/fast-glob/-/fast-glob-2.2.0.tgz#e9d032a69b86bef46fc03d935408f02fb211d9fc"
@@ -3318,10 +3289,6 @@ jest-diff@^22.4.3:
     jest-get-type "^22.4.3"
     pretty-format "^22.4.3"
 
-jest-docblock@^21.0.0:
-  version "21.2.0"
-  resolved "https://registry.yarnpkg.com/jest-docblock/-/jest-docblock-21.2.0.tgz#51529c3b30d5fd159da60c27ceedc195faf8d414"
-
 jest-docblock@^22.4.3:
   version "22.4.3"
   resolved "https://registry.yarnpkg.com/jest-docblock/-/jest-docblock-22.4.3.tgz#50886f132b42b280c903c592373bb6e93bb68b19"