[Proposal] Equal height for all pinned repositories

[razonyang]

Is your feature request related to a problem? Please describe.

Hi, I found that the pinned repos are not equal height.

Describe the solution you'd like

GitHub built-in:

Describe alternatives you've considered

No response

Additional context

No response

[rickstaa]

@razonyang, thanks for your bug report. This is the intended behaviour since we want the card to resize to the repository description automatically, and users are expected to handle the card height themselves using the HTML height attribute. The GitHub pin card this card was based on handling the height change on the profile page.

So I think I prefer to close this issue. However, if @qwerty541 and @anuraghazra think this behaviour is not intended, we can change the minimum size of the repo/pin card to show at least two lines.

<a href="https://github.com/anuraghazra/github-readme-stats">
  <img height="140" align="center" src="https://github-readme-stats.vercel.app/api/pin/?username=anuraghazra&repo=github-readme-stats" />
</a>
<a href="https://github.com/anuraghazra/convoychat">
  <img align="center" src="https://github-readme-stats.vercel.app/api/pin/?username=rickstaa&repo=github-emoji-picker" />
</a>

[razonyang]

@rickstaa Thanks for the code snippet, but the fixed height doesn't look good, equal width and height looks better. The font-size are also smaller than others.

It may better that if the description can take 2 rows, fill up with whitespace if not enough. Please feel free to close it if it's not possible or reasonable. I've solved it by modifying the descriptions.

[rickstaa]

@rickstaa Thanks for the code snippet, but the fixed height doesn't look good, equal width and height looks better. The font-size are also smaller than others.

It may better that if the description can take 2 rows, fill up with whitespace if not enough. Please feel free to close it if it's not possible or reasonable. I've solved it by modifying the descriptions.

Thanks for your feedback. We have the card_width option to change the card width. One way to improve this behaviour is to add a card_height option. Freel free to create a pull request 👍🏻.

[rickstaa]

@rickstaa Thanks for the code snippet, but the fixed height doesn't look good, equal width and height looks better. The font-size are also smaller than others.

It may better that if the description can take 2 rows, fill up with whitespace if not enough. Please feel free to close it if it's not possible or reasonable. I've solved it by modifying the descriptions.

Thanks for your feedback. We have the card_width option to change the card width. One way to improve this behaviour is to add a card_height option. Freel free to create a pull request 👍🏻.

It looks like my previous comment was incorrect 🤔. The card_width argument has not yet been implemented for the pin-card. Feel free to create a pull request or open a new pull request to have this argument and the card_height argument implemented.

[rickstaa]

I re-opened this issue so that @qwerty541 and @anuraghazra can give their opinion.

[qwerty541]

I re-opened this issue so that @qwerty541 and @anuraghazra can give their opinion.

@rickstaa Maybe this behavior is good one to be improved but i think i will be very hard to do working with pure SVG. We can return to this after #1633 will be implemented.

[rickstaa]

I re-opened this issue so that @qwerty541 and @anuraghazra can give their opinion.

@rickstaa Maybe this behavior is good one to be improved but i think i will be very hard to do working with pure SVG. We can return to this after #1633 will be implemented.

I agree let's keep this open for now 👍🏻.