Skip to content

fix: 修复透视表尾列隐藏后的展开icon位置异常 #3102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 20, 2025

Conversation

xxxxZ-zhang
Copy link
Collaborator

@xxxxZ-zhang xxxxZ-zhang commented Feb 20, 2025

👀 PR includes

✨ Feature

  • New feature

🎨 Enhance

  • Code style optimization
  • Refactoring
  • Change the UI
  • Improve the performance
  • Type optimization

🐛 Bugfix

  • Solve the issue and close #0

🔧 Chore

  • Test case
  • Docs / demos update
  • CI / workflow
  • Release version
  • Other ()

📝 Description

🖼️ Screenshot

Before After
iShot_2025-02-20_16 10 15 iShot_2025-02-20_16 12 37

🔗 Related issue link

🔍 Self-Check before the merge

  • Add or update relevant docs.
  • Add or update relevant demos.
  • Add or update test case.
  • Add or update relevant TypeScript definitions.

@github-actions github-actions bot added the pr(fix) bug fix label Feb 20, 2025
Copy link
Contributor

你好 @xxxxZ-zhang,非常感谢你的贡献.
为了让代码更健壮, 请根据 贡献指南 补充相应单元测试 (文档改动或其他特殊场景除外), 如果有 API 改动, 请修改 相应的文档.
同时请检查 linttest 相关 CI 是否通过, 如果失败, 请点击 [Details] 按钮查看, 并根据日志修复.

Hello, @xxxxZ-zhang, Thanks for your contribution. In order to make the code more robust, please add the corresponding unit tests, and update the docs if there are API changes.
At the same time, please check whether the CI related to lint and test passes. If the CI fails, please click [Details] button to check and repair according to the log.

@github-actions github-actions bot added the next 2.0-next 版本的问题 label Feb 20, 2025
@github-actions github-actions bot requested a review from Alexzjt February 20, 2025 08:13
Copy link

Walkthrough

修复了透视表在隐藏尾列后展开图标位置异常的问题。通过调整计算展开图标位置的逻辑,确保图标在隐藏列时正确显示。更新了相关的测试用例以验证修复效果。

Changes

文件 概要
packages/s2-core/tests/spreadsheet/hidden-columns-spec.ts 添加了测试用例以验证隐藏列后展开图标的位置是否正确。
packages/s2-core/src/utils/hide-columns.ts 修改了获取列节点的逻辑,确保在隐藏列时正确处理展开图标位置。

@codecov-commenter
Copy link

codecov-commenter commented Feb 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.80%. Comparing base (ecdc9c8) to head (a325b46).
Report is 623 commits behind head on next.

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #3102      +/-   ##
==========================================
+ Coverage   75.77%   75.80%   +0.03%     
==========================================
  Files         257       51     -206     
  Lines       11994     1492   -10502     
  Branches     2464      284    -2180     
==========================================
- Hits         9088     1131    -7957     
+ Misses       1398      210    -1188     
+ Partials     1508      151    -1357     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Feb 20, 2025

Size Change: -7 B (0%)

Total Size: 619 kB

Filename Size Change
./packages/s2-core/dist/s2-extends.min.js 154 kB -3 B (0%)
./packages/s2-core/dist/s2.min.js 257 kB -4 B (0%)
ℹ️ View Unchanged
Filename Size
./packages/s2-core/dist/s2.min.css 581 B
./packages/s2-react-components/dist/s2-react-components.min.css 2.55 kB
./packages/s2-react-components/dist/s2-react-components.min.js 124 kB
./packages/s2-react/dist/s2-react.min.css 1.74 kB
./packages/s2-react/dist/s2-react.min.js 38.3 kB
./packages/s2-vue/dist/s2-vue.min.css 2.05 kB
./packages/s2-vue/dist/s2-vue.min.js 38.3 kB

compressed-size-action

Copy link
Contributor

你好, @xxxxZ-zhang CI 执行失败, 请点击 [Details] 按钮查看, 并根据日志修复。

Hello, @xxxxZ-zhang CI run failed, please click the [Details] button for detailed log information and fix it.

@github-actions github-actions bot added the 🚨 test failed 单元测试挂了 label Feb 20, 2025
@lijinke666
Copy link
Member

sheet = {
facet: {
getInitColLeafNodes: () => initColumnNodes,
getColNodes: () => initColumnNodes,
},
} as PivotSheet;

@github-actions github-actions bot removed the 🚨 test failed 单元测试挂了 label Feb 20, 2025
@Alexzjt Alexzjt merged commit af6a95d into next Feb 20, 2025
9 checks passed
@Alexzjt Alexzjt deleted the fix/hideColumnIconHoverEvent branch February 20, 2025 08:49
@lijinke666
Copy link
Member

🎉 This PR is included in version @antv/s2-v2.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
next 2.0-next 版本的问题 pr(fix) bug fix released on @latest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants