-
Notifications
You must be signed in to change notification settings - Fork 210
fix: 修复透视表尾列隐藏后的展开icon位置异常 #3102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
你好 @xxxxZ-zhang,非常感谢你的贡献. Hello, @xxxxZ-zhang, Thanks for your contribution. In order to make the code more robust, please add the corresponding unit tests, and update the docs if there are API changes. |
Walkthrough修复了透视表在隐藏尾列后展开图标位置异常的问题。通过调整计算展开图标位置的逻辑,确保图标在隐藏列时正确显示。更新了相关的测试用例以验证修复效果。 Changes
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #3102 +/- ##
==========================================
+ Coverage 75.77% 75.80% +0.03%
==========================================
Files 257 51 -206
Lines 11994 1492 -10502
Branches 2464 284 -2180
==========================================
- Hits 9088 1131 -7957
+ Misses 1398 210 -1188
+ Partials 1508 151 -1357 ☔ View full report in Codecov by Sentry. |
Size Change: -7 B (0%) Total Size: 619 kB
ℹ️ View Unchanged
|
你好, @xxxxZ-zhang CI 执行失败, 请点击 [Details] 按钮查看, 并根据日志修复。 Hello, @xxxxZ-zhang CI run failed, please click the [Details] button for detailed log information and fix it. |
S2/packages/s2-core/__tests__/unit/utils/hide-columns-spec.ts Lines 34 to 39 in a68f134
|
🎉 This PR is included in version @antv/s2-v2.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
👀 PR includes
✨ Feature
🎨 Enhance
🐛 Bugfix
🔧 Chore
📝 Description
🖼️ Screenshot
🔗 Related issue link
🔍 Self-Check before the merge