-
Notifications
You must be signed in to change notification settings - Fork 210
feat: 单元格渲染支持图片、视频 #3101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: 单元格渲染支持图片、视频 #3101
Conversation
你好 @Alexzjt,非常感谢你的贡献. Hello, @Alexzjt, Thanks for your contribution. In order to make the code more robust, please add the corresponding unit tests, and update the docs if there are API changes. |
WalkthroughThis pull request introduces a new feature that enables cell rendering to support images, videos, and rich text. It also resolves issue #3095. The changes involve adding custom renderer configurations and handling media click interactions to provide a preview overlay for media content. Changes
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## next #3101 +/- ##
==========================================
+ Coverage 75.77% 79.89% +4.11%
==========================================
Files 257 217 -40
Lines 11994 11890 -104
Branches 2464 2659 +195
==========================================
+ Hits 9088 9499 +411
+ Misses 1398 789 -609
- Partials 1508 1602 +94 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Size Change: +4.98 kB (+0.8%) Total Size: 625 kB
ℹ️ View Unchanged
|
packages/s2-core/src/interaction/base-interaction/click/data-cell-click.ts
Outdated
Show resolved
Hide resolved
packages/s2-core/src/interaction/base-interaction/click/header-cell-link-click.ts
Outdated
Show resolved
Hide resolved
packages/s2-core/src/interaction/base-interaction/click/media-click.ts
Outdated
Show resolved
Hide resolved
packages/s2-core/src/interaction/base-interaction/click/preview-click.ts
Outdated
Show resolved
Hide resolved
packages/s2-core/src/interaction/base-interaction/click/preview-click.ts
Outdated
Show resolved
Hide resolved
🎉 This PR is included in version @antv/s2-v2.3.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
👀 PR includes
✨ Feature
🎨 Enhance
🐛 Bugfix
🔧 Chore
📝 Description
🖼️ Screenshot
🔗 Related issue link
🔍 Self-Check before the merge