Skip to content

Commit dc220df

Browse files
committed
[#77829] devices: linux-client: shell: Update tests
Signed-off-by: Anna Roszkiewicz <aroszkiewicz@antmicro.com>
1 parent daf26df commit dc220df

File tree

2 files changed

+12
-10
lines changed

2 files changed

+12
-10
lines changed

devices/linux-client/shell/runner_test.go

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ func TestShellRunnerBasic(t *testing.T) {
1616
sr, err := NewShellRunner(1)
1717
assert.NoError(t, err)
1818

19-
_, err = sr.Spawn(TestSessionUuid)
19+
_, err = sr.Spawn(TestSessionUuid, "")
2020
assert.NoError(t, err)
2121
}
2222

@@ -29,11 +29,11 @@ func TestShellRunnerLimits(t *testing.T) {
2929
assert.NoError(t, err)
3030

3131
for i := 0; i < LimitToTest; i += 1 {
32-
_, err = sr.Spawn(strconv.Itoa(i))
32+
_, err = sr.Spawn(strconv.Itoa(i), "")
3333
assert.NoError(t, err)
3434
}
3535

36-
_, err = sr.Spawn(uuid.NewString())
36+
_, err = sr.Spawn(uuid.NewString(), "")
3737
if assert.Error(t, err) {
3838
assert.Equal(t, ErrSessionLimitReached, err)
3939
}
@@ -46,17 +46,17 @@ func TestShellRunnerLimitsIncrementedAfterTermination(t *testing.T) {
4646
id1 := uuid.NewString()
4747
id2 := uuid.NewString()
4848

49-
_, err = sr.Spawn(id1)
49+
_, err = sr.Spawn(id1, "")
5050
assert.NoError(t, err)
5151

52-
_, err = sr.Spawn(id2)
52+
_, err = sr.Spawn(id2, "")
5353
if assert.Error(t, err) {
5454
assert.Equal(t, ErrSessionLimitReached, err)
5555
}
5656

5757
err = sr.Terminate(id1)
5858
assert.NoError(t, err)
5959

60-
_, err = sr.Spawn(id2)
60+
_, err = sr.Spawn(id2, "")
6161
assert.NoError(t, err)
6262
}
Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,31 +1,33 @@
11
package shell
22

33
import (
4+
"os"
45
"testing"
56

67
"github.com/google/uuid"
78
"github.com/stretchr/testify/assert"
89
)
910

1011
func TestSessionSpawn(t *testing.T) {
11-
_, err := NewShellSession(uuid.NewString())
12+
_, err := NewShellSession(uuid.NewString(), "")
1213
assert.NoError(t, err)
1314
}
1415

1516
func TestSessionClose(t *testing.T) {
16-
session, _ := NewShellSession(uuid.NewString())
17+
session, _ := NewShellSession(uuid.NewString(), "")
1718
err := session.Close()
1819
assert.NoError(t, err)
1920
}
2021

2122
func TestSessionCannotFindShell(t *testing.T) {
2223
DefaultShellList = []string{}
23-
_, err := NewShellSession(uuid.NewString())
24+
os.Setenv("SHELL", "/this/path/is/invalid")
25+
_, err := NewShellSession(uuid.NewString(), "")
2426
assert.ErrorIs(t, err, ErrNoShellAvailable)
2527

2628
DefaultShellList = []string{
2729
"/this/path/will/not/exist",
2830
}
29-
_, err = NewShellSession(uuid.NewString())
31+
_, err = NewShellSession(uuid.NewString(), "")
3032
assert.ErrorIs(t, err, ErrNoShellAvailable)
3133
}

0 commit comments

Comments
 (0)