Skip to content

proptery 'shape-image-threshold' should be made Unitless #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mediabuff opened this issue Apr 15, 2025 · 4 comments
Open

proptery 'shape-image-threshold' should be made Unitless #33

mediabuff opened this issue Apr 15, 2025 · 4 comments

Comments

@mediabuff
Copy link

https://developer.mozilla.org/en-US/docs/Web/CSS/shape-image-threshold

@ElderJames
Copy link
Member

Thanks for contacting us @mediabuff , which component are you using?

@yoli799480165
Copy link
Collaborator

https://developer.mozilla.org/en-US/docs/Web/CSS/shape-image-threshold

CssInCsharp uses the keys generated by the unitless to determine whether a unit needs to be added. We will consider adopting other approaches for this in the future.

@mediabuff
Copy link
Author

There is a bug in emotion-js/emotion#3328

Or https://github.com/emotion-js/emotion/blob/main/packages/unitless/src/index.ts

I meant to say that '' needs to be added to

internal static class Unitless

public static Dictionary<string, int> Keys = new Dictionary<string, int>
{
"shape-image-threshold", 1
}
}

Or https://github.com/emotion-js/emotion/blob/main/packages/unitless/src/index.ts

let unitlessKeys: Record<string, 1> = {

"shapeImageThreshold: 1
}

@ElderJames
Copy link
Member

Hi @mediabuff , are you using this library?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants