Cache Body Tessellation (#473)

Co-authored-by: Roberto Pastor Muela <37798125+RobPasMue@users.noreply.github.com>

Author: jonahrb

src/ansys/geometry/core/designer/body.py

@@ -1,6 +1,7 @@
 """Provides the ``Body`` class module."""
 from abc import ABC, abstractmethod
 from enum import Enum
+from functools import wraps
 
 from ansys.api.geometry.v0.bodies_pb2 import (
     CopyRequest,
@@ -410,6 +411,28 @@ def __init__(
         self._is_alive = True
         self._bodies_stub = BodiesStub(self._grpc_client.channel)
         self._commands_stub = CommandsStub(self._grpc_client.channel)
+        self._tessellation = None
+
+    def reset_tessellation_cache(func):
+        """Decorator for ``TemplateBody`` methods that require a tessellation cache update.
+
+        Parameters
+        ----------
+        func : method
+            The method being called.
+
+        Returns
+        -------
+        Any
+            The output of the method, if any.
+        """
+
+        @wraps(func)
+        def wrapper(self: "TemplateBody", *args, **kwargs):
+            self._tessellation = None
+            return func(self, *args, **kwargs)
+
+        return wrapper
 
     @property
     def _grpc_id(self) -> EntityIdentifier:
@@ -581,6 +604,7 @@ def project_curves(
 
     @protect_grpc
     @check_input_types
+    @reset_tessellation_cache
     def translate(self, direction: UnitVector3D, distance: Union[Quantity, Distance, Real]) -> None:
         distance = distance if isinstance(distance, Distance) else Distance(distance)
 
@@ -635,9 +659,12 @@ def tessellate(
 
         self._grpc_client.log.debug(f"Requesting tessellation for body {self.id}.")
 
-        resp = self._bodies_stub.GetTessellation(self._grpc_id)
+        # cache tessellation
+        if not self._tessellation:
+            resp = self._bodies_stub.GetTessellation(self._grpc_id)
+            self._tessellation = resp.face_tessellation.values()
 
-        pdata = [tess_to_pd(tess).transform(transform) for tess in resp.face_tessellation.values()]
+        pdata = [tess_to_pd(tess).transform(transform) for tess in self._tessellation]
         comp = pv.MultiBlock(pdata)
         if merge:
             ugrid = comp.combine()

src/ansys/geometry/core/designer/component.py

@@ -1,7 +1,6 @@
 """Provides the ``Component`` class module."""
 
 from enum import Enum, unique
-from threading import Thread
 import uuid  # TODO: do we even need ID?, maybe use from SC?
 
 from ansys.api.geometry.v0.bodies_pb2 import (
@@ -988,18 +987,9 @@ def tessellate(
         """
         import pyvista as pv
 
-        datasets = []
-
-        def get_tessellation(body: Body):
-            datasets.append(body.tessellate(merge=merge_bodies))
-
         # Tessellate the bodies in this component
-        threads = []
-        for body in self.bodies:
-            thread = Thread(target=get_tessellation, args=(body,))
-            thread.start()
-            threads.append(thread)
-        [thread.join() for thread in threads]
+        datasets = [body.tessellate(merge_bodies) for body in self.bodies]
+
         blocks_list = [pv.MultiBlock(datasets)]
 
         # Now, go recursively inside its subcomponents (with no arguments) and

tests/integration/test_tessellation.py

@@ -2,7 +2,7 @@
 import pytest
 
 from ansys.geometry.core import Modeler
-from ansys.geometry.core.math import Plane, Point2D
+from ansys.geometry.core.math import Plane, Point2D, UnitVector3D, Vector3D
 from ansys.geometry.core.misc.units import UNITS, Quantity
 from ansys.geometry.core.sketch import Sketch
 
@@ -60,6 +60,20 @@ def test_body_tessellate(modeler: Modeler, skip_not_on_linux_service):
     assert mesh_2.n_points == 76
     assert mesh_2.n_arrays == 0
 
+    # Make sure instance body tessellation is the same as original
+    comp_1_instance = design.add_component("Component_1_Instance", comp_1)
+    assert comp_1_instance.bodies[0].tessellate() == comp_1.bodies[0].tessellate()
+
+    # After modifying placement, they should be different
+    comp_1_instance.modify_placement(Vector3D([1, 2, 3]))
+    assert comp_1_instance.bodies[0].tessellate() != comp_1.bodies[0].tessellate()
+
+    assert comp_1.bodies[0]._template._tessellation is not None
+
+    comp_1.bodies[0].translate(UnitVector3D([1, 0, 0]), 1)
+
+    assert comp_1.bodies[0]._template._tessellation is None
+
 
 def test_component_tessellate(modeler: Modeler, skip_not_on_linux_service):
     """Test the component tessellation."""