Merge pull request #709 from Jakuje/session-close

Author: webknjaz

docs/changelog-fragments/709.bugfix.rst

@@ -0,0 +1 @@
+Fixed crash when more operations were called after ``session.close()`` -- by :user:`Jakuje`.

src/pylibsshext/session.pyx

@@ -539,8 +539,6 @@ cdef class Session(object):
         if self._libssh_session is not NULL:
             if libssh.ssh_is_connected(self._libssh_session):
                 libssh.ssh_disconnect(self._libssh_session)
-            libssh.ssh_free(self._libssh_session)
-            self._libssh_session = NULL
 
     def set_missing_host_key_policy(self, policy):
         """The policy to use if the know host key is missing.

tests/unit/session_test.py

@@ -13,6 +13,15 @@ def test_make_session():
     assert Session()
 
 
+def test_make_session_close_connect():
+    """Make sure the session is usable after call to close()."""
+    session = Session()
+    session.close()
+    error_msg = '^ssh connect failed: Hostname required$'
+    with pytest.raises(LibsshSessionException, match=error_msg):
+        session.connect()
+
+
 def test_session_connection_refused(free_port_num):
     """Test that connecting to a missing service raises an error."""
     error_msg = '^ssh connect failed: Connection refused$'