Merge pull request #11 from pycontribs/fix/rhel8

Enable testing on RHEL8

Author: ssbarnea

.travis.yml

@@ -1,21 +1,17 @@
 ---
 dist: xenial
 # Config file for automatic testing at travis-ci.org
-
-sudo: false
 services:
   - docker
 language: python
 
 jobs:
   fast_finish: true
   include:
-    - name: lint
+    # combined env improve execution speed on travis considerably
+    - name: lint,py27,distros
       python: "3.7"
-      env: TOXENV=lint
-    - name: py27
-      python: "2.7"
-      env: TOXENV=py27
+      env: TOXENV=lint,py27,distros
     - name: py35
       python: "3.5"
       env: TOXENV=py35
@@ -37,11 +33,15 @@ install:
   - pip install tox
 
 script:
-  - tox
+  - travis_wait tox
 
 before_cache:
   - rm -rf $HOME/.cache/pip/log
 
+branches:
+  only:
+    - master
+
 cache:
   directories:
     - $HOME/.cache/pip

.yamllint

@@ -0,0 +1,12 @@
+---
+extends: default
+
+rules:
+  document-start: disable
+  line-length:
+    max: 999
+    allow-non-breakable-words: true
+    allow-non-breakable-inline-mappings: true
+  key-duplicates: enable
+ignore: |
+  .tox

README.rst

@@ -29,8 +29,10 @@ Installation
 
 You can install "pytest-molecule" via `pip`_ from `PyPI`_::
 
-    $ pip install pytest-molecule
+    $ PIP_NO_BUILD_ISOLATION=false pip install pytest-molecule
 
+PIP_NO_BUILD_ISOLATION is needed only on ancient python distributions to workaround
+https://github.com/pypa/pip/issues/5229
 
 Contributing
 ------------

tests/roles/ensure-ansible/meta/main.yml

@@ -0,0 +1,29 @@
+---
+galaxy_info:
+  author: Sorin Sbarnea
+  description: Role that does nothing
+  license: MIT
+
+  min_ansible_version: 2.6
+
+  platforms:
+    - name: Fedora
+      versions:
+        - 28
+        - 29
+        - 30
+    - name: CentOS
+      versions:
+        - 7
+    - name: RHEL
+      versions:
+        - 7
+        - 8
+    - name: Ubuntu
+      versions:
+        - Xenial
+        - Bionic
+
+  galaxy_tags: []
+
+dependencies: []

tests/roles/ensure-ansible/molecule/Dockerfile.j2

@@ -0,0 +1,12 @@
+# Molecule managed
+
+{% if item.registry is defined %}
+FROM {{ item.registry.url }}/{{ item.image }}
+{% else %}
+FROM {{ item.image }}
+{% endif %}
+
+# Required by RHEL8 image which defaults to non root
+USER root
+
+CMD ["sh", "-c", "while true; do sleep 10000; done"]

tests/roles/ensure-ansible/molecule/default/molecule.yml

@@ -0,0 +1,44 @@
+---
+driver:
+  name: docker
+
+platforms:
+
+  - name: centos7
+    hostname: centos7
+    image: centos:7
+    dockerfile: ../Dockerfile.j2
+
+  - name: fedora
+    hostname: fedora
+    image: fedora:latest
+    dockerfile: ../Dockerfile.j2
+
+  - name: rhel8
+    hostname: rhel8
+    image: ubi8/python-36
+    registry:
+      url: registry.access.redhat.com
+    dockerfile: ../Dockerfile.j2
+
+  - name: ubuntu
+    hostname: ubuntu
+    image: ubuntu:latest
+    dockerfile: ../Dockerfile.j2
+
+provisioner:
+  name: ansible
+  env:
+    ANSIBLE_STDOUT_CALLBACK: yaml
+  log: true
+
+scenario:
+  test_sequence:
+    - destroy
+    - create
+    - prepare
+    - converge
+    - destroy
+
+lint:
+  enabled: false

tests/roles/ensure-ansible/molecule/default/playbook.yml

@@ -0,0 +1,42 @@
+---
+
+- name: Converge
+  hosts: all
+  # avoid gather as setup module fails when python is missing (ubuntu:latest)
+  gather_facts: false
+  vars:
+    test_dir: /root/src
+  tasks:
+
+    - name: ensure-ansible role
+      include_role:
+        name: ensure-ansible
+
+    - name: Create a directory if it does not exist
+      file:
+        path: "{{ test_dir }}"
+        state: directory
+        mode: '0755'
+
+    - name: Deploy package wheel(s)
+      copy:
+        src: "{{ item }}"
+        dest: "{{ test_dir }}/"
+      with_fileglob:
+        - "{{ playbook_dir }}/../../../../../dist/*.whl"
+
+    # Setting locales to avoid click error:
+    # https://click.palletsprojects.com/en/7.x/python3/
+    # we really need a minimum version of setuptools
+    # PIP_NO_BUILD_ISOLATION workaround for older pips with partial pep514
+    - name: Test install to user
+      shell: |
+        set -euox pipefail
+        export LC_ALL=C.UTF-8
+        export LANG=C.UTF-8
+        {{ ansible_python.executable }} -m pip install --user 'setuptools>=40.0'
+        PIP_NO_BUILD_ISOLATION=false {{ ansible_python.executable }} -m pip install --user {{ test_dir }}/*.whl
+        {{ ansible_python.executable }} -m molecule --version
+      args:
+        # ubuntu defaults to /bin/sh which chokes on pipefail
+        executable: /bin/bash

tests/roles/ensure-ansible/tasks/main.yml

@@ -0,0 +1,41 @@
+---
+
+- name: gather_fact fallback block
+  block:
+    - name: Attempt to gather facts
+      setup:
+        gather_subset: all
+
+  rescue:
+    - name: Attempt to bootstrap python
+      become_user: root
+      raw: |
+        /bin/bash -c "apt-get update && apt-get install -y python3 python3-apt sudo"
+
+    - name: Retry gather facts
+      setup:
+        gather_subset: all
+
+- name: Include OS specific variables
+  include_vars: "{{ item }}"
+  failed_when: false
+  loop:
+    - "{{ ansible_os_family | lower }}.yml"
+    - "{{ ansible_os_family | lower }}-{{ ansible_distribution_major_version | lower }}.yml"
+    - "{{ ansible_distribution | lower }}.yml"
+    - "{{ ansible_distribution | lower }}-{{ ansible_distribution_major_version | lower }}.yml"
+    - "{{ ansible_distribution | lower }}-{{ ansible_distribution_version.split('.')[0:2] | join('-') | lower }}.yml"
+    - "{{ ansible_distribution | lower }}-{{ ansible_distribution_version.split('.')[0:3] | join('-') | lower }}.yml"
+
+# at this stage we may not even have sudo installed
+- name: pre-install system packages
+  when: pre_packages is defined
+  become_user: root
+  package:
+    name: "{{ pre_packages }}"
+
+- name: install system packages
+  when: packages is defined
+  become: true
+  package:
+    name: "{{ packages }}"

tests/roles/ensure-ansible/vars/centos-7.yml

@@ -0,0 +1,12 @@
+# packages to be installed ASAP, like those enabling new repos
+pre_packages:
+  - epel-release
+  - sudo
+
+packages:
+  - bash
+  - rsync
+  - gcc  # compiling psutil
+  - python2-devel
+  - python2-pip
+  - python2-psutil

tests/roles/ensure-ansible/vars/redhat-8.yml

@@ -0,0 +1,12 @@
+pre_packages:
+  - sudo
+
+packages:
+  - bash
+  - rsync
+  - gcc  # compiling psutil
+  - python36-devel
+  - python3-libselinux
+
+# RHEL 8 is missing:
+# python3-psutil