Skip to content

Commit c6597f7

Browse files
authored
Add support for FiftyGigabitEthernet (#1115)
* Add support for FiftyGigabitEthernet * add a changelog
1 parent 89d11a7 commit c6597f7

File tree

4 files changed

+16
-2
lines changed

4 files changed

+16
-2
lines changed
Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
---
2+
bugfixes:
3+
- ios_interfaces - Fixes rendering of FiftyGigabitEthernet as it was wrongly rendering FiftyGigabitEthernet as FiveGigabitEthernet.

plugins/module_utils/network/ios/ios.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -141,8 +141,10 @@ def _get_number(name):
141141
if_type = "FastEthernet"
142142
elif name.lower().startswith("fo"):
143143
if_type = "FortyGigabitEthernet"
144-
elif name.lower().startswith("fi"):
144+
elif name.lower().startswith("fiv"):
145145
if_type = "FiveGigabitEthernet"
146+
elif name.lower().startswith("fif"):
147+
if_type = "FiftyGigabitEthernet"
146148
elif name.lower().startswith("et"):
147149
if_type = "Ethernet"
148150
elif name.lower().startswith("vl"):

plugins/module_utils/network/ios/utils/utils.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -286,8 +286,10 @@ def _get_number(name):
286286
if_type = "FastEthernet"
287287
elif name.lower().startswith("fo"):
288288
if_type = "FortyGigabitEthernet"
289-
elif name.lower().startswith("fi"):
289+
elif name.lower().startswith("fiv"):
290290
if_type = "FiveGigabitEthernet"
291+
elif name.lower().startswith("fif"):
292+
if_type = "FiftyGigabitEthernet"
291293
elif name.lower().startswith("long"):
292294
if_type = "LongReachEthernet"
293295
elif name.lower().startswith("et"):

tests/unit/modules/network/ios/test_ios_interfaces.py

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -678,6 +678,10 @@ def test_ios_interfaces_rendered(self):
678678
"name": "fiveGigabitEthernet",
679679
"description": "Ansible UT FiveGigabitEthernet",
680680
},
681+
{
682+
"name": "fiftyGigabitEthernet",
683+
"description": "Ansible UT for fiftyGigabitEthernet",
684+
},
681685
{
682686
"name": "ethernet1",
683687
"description": "Ansible UT Ethernet",
@@ -750,6 +754,9 @@ def test_ios_interfaces_rendered(self):
750754
"interface FiveGigabitEthernet",
751755
"description Ansible UT FiveGigabitEthernet",
752756
"no shutdown",
757+
"interface FiftyGigabitEthernet",
758+
"description Ansible UT for fiftyGigabitEthernet",
759+
"no shutdown",
753760
"interface Ethernet1",
754761
"description Ansible UT Ethernet",
755762
"no shutdown",

0 commit comments

Comments
 (0)