Skip to content

Commit 2cb77df

Browse files
alehaaroverflow
andauthored
Fix typo in ios_service module (#1101)
* Fix typo in ios_service module * Fix msec typo in additional test cases * Add changelog for #1101 --------- Co-authored-by: Vinay M <63404819+roverflow@users.noreply.github.com>
1 parent 387374d commit 2cb77df

File tree

3 files changed

+10
-7
lines changed

3 files changed

+10
-7
lines changed
Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
---
2+
bugfixes:
3+
- ios_service - Fix a typo causing log timestamps not being configurable

plugins/module_utils/network/ios/rm_templates/service.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ def handleTimestamp(config_data):
2929

3030
if config_data.get("datetime_options"):
3131
datetime_op = config_data.get("datetime_options")
32-
command += " mesc" if datetime_op.get("msec") else ""
32+
command += " msec" if datetime_op.get("msec") else ""
3333
command += " localtime" if datetime_op.get("localtime") else ""
3434
command += " show-timezone" if datetime_op.get("show_timezone") else ""
3535
command += " year" if datetime_op.get("year") else ""

tests/unit/modules/network/ios/test_ios_service.py

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -129,8 +129,8 @@ def test_ios_service_merged(self):
129129
}
130130
merged = [
131131
"service password-encryption",
132-
"service timestamps debug uptime mesc",
133-
"service timestamps log datetime mesc localtime show-timezone year",
132+
"service timestamps debug uptime msec",
133+
"service timestamps log datetime msec localtime show-timezone year",
134134
]
135135
playbook["state"] = "merged"
136136
set_module_args(playbook)
@@ -217,7 +217,7 @@ def test_ios_service_overridden(self):
217217
"service password-encryption",
218218
"service tcp-keepalives-in",
219219
"service tcp-keepalives-out",
220-
"service timestamps log datetime mesc localtime show-timezone year",
220+
"service timestamps log datetime msec localtime show-timezone year",
221221
"service timestamps debug datetime",
222222
]
223223
playbook["state"] = "overridden"
@@ -276,8 +276,8 @@ def test_ios_service_replaced(self):
276276
"service password-encryption",
277277
"service tcp-keepalives-in",
278278
"service tcp-keepalives-out",
279-
"service timestamps log datetime mesc localtime show-timezone year",
280-
"service timestamps debug datetime mesc localtime",
279+
"service timestamps log datetime msec localtime show-timezone year",
280+
"service timestamps debug datetime msec localtime",
281281
]
282282
playbook["state"] = "replaced"
283283
set_module_args(playbook)
@@ -500,7 +500,7 @@ def test_ios_service_rendered(self):
500500
"service tcp-keepalives-in",
501501
"service tcp-keepalives-out",
502502
"service timestamps debug uptime localtime",
503-
"service timestamps log datetime mesc localtime show-timezone year",
503+
"service timestamps log datetime msec localtime show-timezone year",
504504
]
505505
result = self.execute_module(changed=False)
506506
self.maxDiff = None

0 commit comments

Comments
 (0)