Scope syntax coloring to juvix #161
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix the overly broad scope configuration that causes the extension to affect non-semantic syntax coloring across all languages. anoma#160
lukaszcz
reviewed
May 27, 2025
package.json
Outdated
| "module.juvix" | ||
| ], | ||
| "number": [ | ||
| "numeric.juvix" |
There was a problem hiding this comment.
Shouldn't this be number.juvix, as used in other places?
There was a problem hiding this comment.
Good catch, I can confirm that numbers are highlighted correctly now.
|
Thanks for this PR! We didn't notice the issue before. |
lachrist
force-pushed
the
scope-syntax-coloring
branch
from
d21f0ee to
469d1a6
Compare
Fix the overly broad scope configuration that causes the extension to affect semantic syntax coloring across all languages. anoma#160
lachrist
force-pushed
the
scope-syntax-coloring
branch
from
469d1a6 to
cf06e4a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scope syntax coloring to Juviх by consistently adding a
.juvixsuffix to both regular and semantic token types.Fixes #160